Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include self.__set_params in the recommend BaseRecommender method #15

Closed
marcelcaraciolo opened this issue May 22, 2011 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@marcelcaraciolo
Copy link
Member

It is necessary to set the params in the recommend BaseRecommender method by calling self.__set_params(**params) from BaseEstimator.

How to put this in the BaseRecommender without calling super in the Child Class?

@ghost ghost assigned marcelcaraciolo May 22, 2011
@marcelcaraciolo
Copy link
Member Author

I am thinking in adding a docs to the developer in the BaseRecommender suggesting the developer to store the params using the self setter methods.

@ghost ghost assigned marcelcaraciolo May 23, 2011
@marcelcaraciolo
Copy link
Member Author

There is no solution for this since the set_params is for updating the existing attributes and not to add new ones.
Check scikit-learn for more details (BaseEstimator)
https://github.com/scikit-learn/scikit-learn/blob/master/scikits/learn/base.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant