Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying synth track does not copy pan and volume of track #1021

Closed
StaffanMelin opened this issue Jun 1, 2021 · 9 comments
Closed

Copying synth track does not copy pan and volume of track #1021

StaffanMelin opened this issue Jun 1, 2021 · 9 comments

Comments

@StaffanMelin
Copy link
Contributor

I select a synth track, right click and select duplicate track. I check the bottom three checkboxes (see attachment).

But the pan and volume of the duplicated track are not copies, only the default values.

muse_duplicate_track

MusE 4.0 (compiled from master a week ago)

@StaffanMelin StaffanMelin changed the title Copying synth track Copying synth track does not copy pan and volume of track Jun 1, 2021
@terminator356
Copy link
Member

Should be fixed in git master now. Thanks for spotting that, been there a long time. Re-open if any trouble.

@StaffanMelin
Copy link
Contributor Author

Works great, thanks Tim! :)

I noticed that plugins are copied, but not their settings. Is this possible to add, @terminator356 ?

@terminator356
Copy link
Member

It is supposed to. I stepped through the code and found the problem.
It is attempting to copy the existing synth track's controller values to the new synth track copy
before the new copy's synth section is instantiated, so there's nothing to copy the values to,
and the new copy ends up with default values, after it has been created.
Thanks for spotting, again. I think I have a fix, must try...

@terminator356 terminator356 reopened this Jun 4, 2021
@StaffanMelin
Copy link
Contributor Author

Thank you for looking into this Tim, I am sure the solution will benefit many!

@terminator356
Copy link
Member

Should be fixed in git master now.
Tested the various copy dialog options OK with synth tracks and other audio tracks having effect rack plugins
and having static controller values and controller graphs.

@terminator356
Copy link
Member

terminator356 commented Jun 5, 2021

Final note:
Special: Copying MESS synth tracks is a slightly different experience.
Their controllers are midi controllers, not audio controllers like the other synths.
That midi controller data is contained in midi parts, and therefore in this case copying is operated by the
track copy dialog's parts options.

@StaffanMelin
Copy link
Contributor Author

StaffanMelin commented Jun 5, 2021

Hmmm I get a "segmentation fault" when I did the following with the new version:

  1. Created empty new project
  2. Created a synth track with Surge softsynth
  3. Opened Surge and changed to anyother preset
  4. Right clicked on the synth track and selected "Duplicate track".
  5. Crash

If I only do steps 1, 2, 4 (skip step 3) it works (but is kind of pointless :) )!

@terminator356
Copy link
Member

Can you tell me which version of surge? I am having difficulty figuring out what to download.
Did you build it yourself? VST2 or LV2 version?

Does it happen with other synth plugins?

@StaffanMelin
Copy link
Contributor Author

It is Surge LV2 version 1.7, downloaded från kx.studio as a deb.

I also tried with Helm LV2, it doesn't crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants