You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed a weird behavior of the formatting of my domain name, though.
As shown in the screenshot, the parts after the second "2" is missing.
At first, I thought it was because of the length, but then I saw there were even longer domain names like "mischief.findmysoft.com", so I looked into the code and found
.match(/[a-z1-3.]*/g)[0] +"↗"//capture just the domain and nothing after
The regex only keeps numbers 1, 2, and 3, which would truncate my domain name as soon as it sees the "5".
Are there any reasons behind this design? Thinking about it more, I could see it would also truncate domain names with hyphens, or even international domain names containing Unicode.
If a filter is necessary, maybe changing the regex to /[a-z0-9\-.]*/g would be a good start? It would support most domain names, while ignoring rarely used Unicode ones for now.
The text was updated successfully, but these errors were encountered:
Hi, I'm the author of Jade (https://dragonman225.js.org/jade.html). Thanks for including my work in the collection!
I noticed a weird behavior of the formatting of my domain name, though.
![Screen Shot 2022-10-01 at 2 06 33 PM](https://user-images.githubusercontent.com/25148955/193395342-ebf0fbaf-ec06-4b44-b597-9d94bc6d572d.png)
As shown in the screenshot, the parts after the second "2" is missing.
At first, I thought it was because of the length, but then I saw there were even longer domain names like "mischief.findmysoft.com", so I looked into the code and found
infinitecanvas.tools/src/pages/gallery.astro
Line 43 in a2177e1
The regex only keeps numbers 1, 2, and 3, which would truncate my domain name as soon as it sees the "5".
Are there any reasons behind this design? Thinking about it more, I could see it would also truncate domain names with hyphens, or even international domain names containing Unicode.
If a filter is necessary, maybe changing the regex to
/[a-z0-9\-.]*/g
would be a good start? It would support most domain names, while ignoring rarely used Unicode ones for now.The text was updated successfully, but these errors were encountered: