Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent option to images #43

Closed
ianyimi opened this issue Jun 3, 2021 · 3 comments
Closed

Add transparent option to images #43

ianyimi opened this issue Jun 3, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@ianyimi
Copy link
Contributor

ianyimi commented Jun 3, 2021

Allow for png images to be shown without a background on the image component

@ianyimi ianyimi added the enhancement New feature or request label Jun 3, 2021
@AlaricBaraou
Copy link
Contributor

I can enable image transparency for .png by setting transparent to true on the image material.
But when used with a frame, it will use the color of the frame as a background.

Do we need the inside of the frame to be transparent when used with a png ?
If yes, the frame component will need some adjustments otherwise it's just about the transparent property on the image material.

Also if I understood correctly, it's up to the user to enable this transparency or not right ?
Or are we going with a default transparent material when a .png is used ?

I see pro and cons to both approch.

I'll do a PR when I'll have those infos :)

@ianyimi
Copy link
Contributor Author

ianyimi commented Jun 5, 2021

Thanks for this note I forgot about the frame back. Transparency doesn't need to be the default setting. I think it would be nice to have the inside of the frame be transparent as well and it shouldn't be too difficult a fix either. Also yes, the user will be able to toggle transparency.

@ianyimi
Copy link
Contributor Author

ianyimi commented Jun 5, 2021

Also I just thought of this but it would be cool as well to add a frameColor attribute to the image component, but I'll make a new issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants