-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Issue] Cannot delete bars with Ctrl+Del in Windows #10476
Comments
I agree Ctrl+Delete is the expected shortcut here. But just one minor point of clarification - for historical reasons, these are usually independent shortcuts, and in note input mode specifically, they do different things. Delete is delete, Backspace has generally been an alias for undo. Not saying this should necessarily be taken forward, but probably we should take a look at the bigger picture here. I suspect that only keyboards designed for Windows typically even have these as independent keys, and on macOS specifically I think the shortcuts have traditionally been customized (by us) to not require Fn activate the Delete functionality, but when using keyboards that lack independent Backspace and Delete keys on Windows or Linux, results can be unexpected at times. |
heyy, may I work on this? |
I don't see why not! |
@Kissh12 Could you confirm if you are still working on this? Edit: For some reason, I am unable to reproduce the issue at all |
yes yes, I am working on it |
can you help me a little please with this problem, as I am new to open source contributions. |
I would absolutely love to but I am unable to reproduce the problem itself :( |
ohh, so what should I do now?? Also, I am looking forward to contributing with musescore in gsoc, can you please guide me on that and tell me a platform to connect and learn further from you? It would be my pleasure sir |
@Kissh12 Hey! I am also just a contributor like you, I suggest you join MuseScore's server to communicate with plethora of people (including me) there! https://discord.gg/gnpWDhQw |
thanks a lot |
Any movement on this? |
Hey if the issue was not resolved can you assign it to me ? I will be glad to work on it. |
@GargDivanshu, feel free, assuming this bug is still active? Perhaps someone on Windows can confirm? The basic idea is that we want the Delete and Backspace keys to be equivalent except when editing text. This should mean looking for shortcuts involving one of those keys in shortcuts.xml and adding the other key as an alternative combination. However, it looks like that has already been done in several places, so either the bug is fixed or there's an underlying problem that needs to be resolved. |
Just built the current master branch in Windows (10) at time of this writing, and I cannot reproduce the bug anymore; all Ctrl+Del, Ctrl+Backspace, Ctrl+Shift+Del, and Ctrl+Shift+Backspace works for their function in shortcuts.xml |
Just checked on Windows and Linux now, and indeed this appears to have been fixed somewhere along the way. |
Describe the bug
Ctrl+Backspace will delete a selected bar (or bars), but Ctrl+Delete has no effect.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Ctrl+Delete should work identically to Ctrl+Backspace. (I assume that Delete and Backspace should be interchangeable in all contexts?)
Platform information
(Reliable Sources tell me that Cmd+Delete and Cmd+Backspace work identically on Mac, as they should)
The text was updated successfully, but these errors were encountered: