Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Cannot delete bars with Ctrl+Del in Windows #10476

Closed
oktophonie opened this issue Feb 7, 2022 · 15 comments
Closed

[MU4 Issue] Cannot delete bars with Ctrl+Del in Windows #10476

oktophonie opened this issue Feb 7, 2022 · 15 comments
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P3 Priority: Low

Comments

@oktophonie
Copy link
Contributor

Describe the bug
Ctrl+Backspace will delete a selected bar (or bars), but Ctrl+Delete has no effect.

To Reproduce
Steps to reproduce the behavior:

  1. Select an entire bar, or multiple bars
  2. Press Ctrl+Del
  3. (watch as nothing happens)

Expected behavior
Ctrl+Delete should work identically to Ctrl+Backspace. (I assume that Delete and Backspace should be interchangeable in all contexts?)

Platform information

  • OS: Windows 11
    (Reliable Sources tell me that Cmd+Delete and Cmd+Backspace work identically on Mac, as they should)
@oktophonie oktophonie added the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Feb 7, 2022
@MarcSabatella
Copy link
Contributor

I agree Ctrl+Delete is the expected shortcut here. But just one minor point of clarification - for historical reasons, these are usually independent shortcuts, and in note input mode specifically, they do different things. Delete is delete, Backspace has generally been an alias for undo. Not saying this should necessarily be taken forward, but probably we should take a look at the bigger picture here. I suspect that only keyboards designed for Windows typically even have these as independent keys, and on macOS specifically I think the shortcuts have traditionally been customized (by us) to not require Fn activate the Delete functionality, but when using keyboards that lack independent Backspace and Delete keys on Windows or Linux, results can be unexpected at times.

@Kissh12
Copy link

Kissh12 commented Apr 5, 2022

heyy, may I work on this?

@oktophonie
Copy link
Contributor Author

I don't see why not!

@VanSHOE
Copy link
Contributor

VanSHOE commented Apr 10, 2022

@Kissh12 Could you confirm if you are still working on this?

Edit: For some reason, I am unable to reproduce the issue at all
Both Ctrl+Del and Ctrl+Backspace seem to be deleting the bars for me

@Kissh12
Copy link

Kissh12 commented Apr 11, 2022

@Kissh12 Could you confirm if you are still working on this?

Edit: For some reason, I am unable to reproduce the issue at all Both Ctrl+Del and Ctrl+Backspace seem to be deleting the bars for me

yes yes, I am working on it

@Kissh12
Copy link

Kissh12 commented Apr 11, 2022

@Kissh12 Could you confirm if you are still working on this?

Edit: For some reason, I am unable to reproduce the issue at all Both Ctrl+Del and Ctrl+Backspace seem to be deleting the bars for me

can you help me a little please with this problem, as I am new to open source contributions.

@VanSHOE
Copy link
Contributor

VanSHOE commented Apr 11, 2022

@Kissh12 Could you confirm if you are still working on this?
Edit: For some reason, I am unable to reproduce the issue at all Both Ctrl+Del and Ctrl+Backspace seem to be deleting the bars for me

can you help me a little please with this problem, as I am new to open source contributions.

I would absolutely love to but I am unable to reproduce the problem itself :(

@Kissh12
Copy link

Kissh12 commented Apr 11, 2022

@Kissh12 Could you confirm if you are still working on this?
Edit: For some reason, I am unable to reproduce the issue at all Both Ctrl+Del and Ctrl+Backspace seem to be deleting the bars for me

can you help me a little please with this problem, as I am new to open source contributions.

I would absolutely love to but I am unable to reproduce the problem itself :(

ohh, so what should I do now?? Also, I am looking forward to contributing with musescore in gsoc, can you please guide me on that and tell me a platform to connect and learn further from you? It would be my pleasure sir

@VanSHOE
Copy link
Contributor

VanSHOE commented Apr 11, 2022

@Kissh12 Hey! I am also just a contributor like you, I suggest you join MuseScore's server to communicate with plethora of people (including me) there! https://discord.gg/gnpWDhQw

@Kissh12
Copy link

Kissh12 commented Apr 11, 2022

@Kissh12 Hey! I am also just a contributor like you, I suggest you join MuseScore's server to communicate with plethora of people (including me) there! https://discord.gg/gnpWDhQw

thanks a lot

@Tantacrul
Copy link
Contributor

Any movement on this?

@Tantacrul Tantacrul added the P3 Priority: Low label May 30, 2022
@Tantacrul Tantacrul added this to To do in Keyboard navigation and shortcuts via automation May 30, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation May 30, 2022
@GargDivanshu
Copy link

Hey if the issue was not resolved can you assign it to me ? I will be glad to work on it.

@shoogle
Copy link
Contributor

shoogle commented Sep 13, 2022

@GargDivanshu, feel free, assuming this bug is still active? Perhaps someone on Windows can confirm?

The basic idea is that we want the Delete and Backspace keys to be equivalent except when editing text. This should mean looking for shortcuts involving one of those keys in shortcuts.xml and adding the other key as an alternative combination. However, it looks like that has already been done in several places, so either the bug is fixed or there's an underlying problem that needs to be resolved.

@poypoyan
Copy link
Contributor

Just built the current master branch in Windows (10) at time of this writing, and I cannot reproduce the bug anymore; all Ctrl+Del, Ctrl+Backspace, Ctrl+Shift+Del, and Ctrl+Shift+Backspace works for their function in shortcuts.xml

@oktophonie
Copy link
Contributor Author

Just checked on Windows and Linux now, and indeed this appears to have been fixed somewhere along the way.

Keyboard navigation and shortcuts automation moved this from To do to Done Oct 13, 2022
4.x SHORTLIST automation moved this from To do to Done Oct 13, 2022
@oktophonie oktophonie removed this from Done in 4.x SHORTLIST Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P3 Priority: Low
Development

No branches or pull requests

8 participants