Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Default workspace name not translatable, because logic relies on it #12658

Open
cbjeukendrup opened this issue Aug 3, 2022 · 4 comments
Assignees
Labels
P2 Priority: Medium

Comments

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Aug 3, 2022

Describe the bug
The name of the default workspace ("Default") is not translatable, and we can't easily make it translatable because there is some logic relying on it (logic to determine which one is the built-in default workspace).

To Reproduce
Steps to reproduce the behavior:

  1. See status bar, and see the source code, workspacetypes.h

We should make a better way to determine which workspace is the default one, instead of relying on the name. (I don't think we should still have logic relying on the name after we make it translatable. Relying on translatable names is asking for trouble, if you ask me.)

(For the translators, this doesn't have high priority, because the string "Default" already exists in other contexts, so Transifex's translation memory will just copy the translation from those strings.)

@cbjeukendrup
Copy link
Contributor Author

cbjeukendrup commented Aug 3, 2022

In fact, the only reason that we need to check whether a workspace is the default one, is that we don't allow deleting the default workspace. Do we really want to disallow this? Or do we rather want that the user can simply not delete the last remaining workspace (i.e. there always has to exist at least one workspace)?

@Tantacrul
Copy link
Contributor

@cbjeukendrup - we specified that the default workspace can't be deleted in case users really need it to revert settings they messed up. I don't have opinions on how this should be achieved.

@Tantacrul Tantacrul added the P2 Priority: Medium label Aug 15, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Aug 15, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - GENERAL] via automation Aug 15, 2022
@cbjeukendrup
Copy link
Contributor Author

But when the user makes changes without creating a new workspace first, this is saved in the default workspace. So, when you just start using MuseScore, you are in the default workspace, and if you then mess up workspace-related settings, these will be stored in the default workspace, so there isn't anything you can switch back to. (The only thing you can do to revert the messed-up 'default' workspace to the real default, is doing a factory reset (or deleting the workspace file from hidden user folders).)

@Tantacrul
Copy link
Contributor

yeah, you're right. Oh well then. The option to just enforce '1 workspace at all times' is good.

We'll need to spruce up this system in other releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

3 participants