Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Selected key signature not announced in New Score dialog (macOS) #13599

Closed
shoogle opened this issue Oct 3, 2022 · 5 comments · Fixed by #19858
Closed

[Accessibility] Selected key signature not announced in New Score dialog (macOS) #13599

shoogle opened this issue Oct 3, 2022 · 5 comments · Fixed by #19858
Labels
accessibility Issues related to accessibility community Issues we would like the community to address os: macOS Potentially specific to the macOS operating system P2 Priority: Medium

Comments

@shoogle
Copy link
Contributor

shoogle commented Oct 3, 2022

Describe the bug
In the New Score dialog's Key Signature chooser popup, screen readers announce which key signature has focus but they do not announce whether or not it is selected.

To Reproduce
Steps to reproduce the behavior:

  1. File > New
  2. Pick any template. Next.
  3. Expand the Key signature popup.
  4. Navigate the popup with arrow keys and tab.

Expected behavior
The screen reader announces the name of the key signature that has focus. It should also do either/both of the following:

  • Say "selected" or "checked" if the focussed key signature is also the selected one.
  • Say "not selected" or "not checked" when any non-selected key signature has focus.

It's not necessary to do both of these things as long as the screen reader does one of them correctly and just says the name for the other key signatures. However, currently NVDA says "not selected" for all key signatures and Narrator just says the name for all of them.

Screenshots

The selected key signature is highlighted in blue. The focussed one has a black outline.

Platform information

  • OS: Windows 10 running NVDA or Narrator screen readers

Additional context
Speech does work for the note chooser in the Tempo popup, so the key signature chooser could be implemented in the same way.

@shoogle shoogle added P2 Priority: Medium community Issues we would like the community to address labels Oct 3, 2022
@shoogle shoogle added this to To do in [MU4.0 - ACCESSIBILITY] via automation Oct 3, 2022
@shoogle shoogle added this to Needs triage in [MU4.0 BETA1] via automation Oct 3, 2022
@RomanPudashkin RomanPudashkin moved this from Needs triage to Low priority in [MU4.0 BETA1] Oct 4, 2022
@DmitryArefiev
Copy link
Contributor

@shoogle @Tantacrul Moving to Beta2 since it's not critical. Please return back if disagree.

@DmitryArefiev DmitryArefiev removed this from Low priority in [MU4.0 BETA1] Oct 4, 2022
@DmitryArefiev DmitryArefiev added this to To do in 4.x SHORTLIST via automation Oct 4, 2022
@oktophonie oktophonie added the accessibility Issues related to accessibility label Jul 28, 2023
@oktophonie oktophonie removed this from To do in [MU4.0 - ACCESSIBILITY] Jul 28, 2023
@shoogle shoogle changed the title [MU4 Issue] [Accessibility] Selected key signature not announced in New Score dialog [Accessibility] Selected key signature not announced in New Score dialog Sep 27, 2023
@shubham-shinde-442
Copy link
Contributor

I Would like to work on this issue.

@shubham-shinde-442
Copy link
Contributor

shubham-shinde-442 commented Feb 27, 2024

You can close this issue, because screen readers is already announcing one of the state correctly.

@shoogle
Copy link
Contributor Author

shoogle commented Feb 27, 2024

I've confirmed that key signatures in the New Score dialog are spoken by NVDA and Narrator on Windows.

If someone on macOS can confirm with VoiceOver (shortcut: Cmd+F5) then I think we can close this.

@DmitryArefiev
Copy link
Contributor

@shoogle Tried on my side. Looks good on Windows and Narrator (was fixed in 4.2.0).
But still occurs on Mac (4.4 master on macOS13.6)

Screen.Recording.2024-03-03.at.14.29.10.mov

@DmitryArefiev DmitryArefiev changed the title [Accessibility] Selected key signature not announced in New Score dialog [Accessibility] Selected key signature not announced in New Score dialog (macOS) Mar 3, 2024
@cbjeukendrup cbjeukendrup added the os: macOS Potentially specific to the macOS operating system label Mar 3, 2024
@shubham-shinde-442 shubham-shinde-442 removed their assignment Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility community Issues we would like the community to address os: macOS Potentially specific to the macOS operating system P2 Priority: Medium
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants