-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Selected key signature not announced in New Score dialog (macOS) #13599
Comments
@shoogle @Tantacrul Moving to Beta2 since it's not critical. Please return back if disagree. |
I Would like to work on this issue. |
You can close this issue, because screen readers is already announcing one of the state correctly. |
I've confirmed that key signatures in the New Score dialog are spoken by NVDA and Narrator on Windows. If someone on macOS can confirm with VoiceOver (shortcut: Cmd+F5) then I think we can close this. |
@shoogle Tried on my side. Looks good on Windows and Narrator (was fixed in 4.2.0). Screen.Recording.2024-03-03.at.14.29.10.mov |
Describe the bug
In the New Score dialog's Key Signature chooser popup, screen readers announce which key signature has focus but they do not announce whether or not it is selected.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The screen reader announces the name of the key signature that has focus. It should also do either/both of the following:
It's not necessary to do both of these things as long as the screen reader does one of them correctly and just says the name for the other key signatures. However, currently NVDA says "not selected" for all key signatures and Narrator just says the name for all of them.
Screenshots
The selected key signature is highlighted in blue. The focussed one has a black outline.
![](https://user-images.githubusercontent.com/11011881/193600743-c4eba246-ba25-457e-9cd3-38540b8fbb6f.png)
Platform information
Additional context
![](https://user-images.githubusercontent.com/11011881/193603094-898d460d-8137-478c-b8e7-cfe65849304d.png)
Speech does work for the note chooser in the Tempo popup, so the key signature chooser could be implemented in the same way.
The text was updated successfully, but these errors were encountered: