Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Incorrect repeat when section break is present #14262

Open
SamYeh opened this issue Nov 2, 2022 · 9 comments
Open

[MU4 Issue] Incorrect repeat when section break is present #14262

SamYeh opened this issue Nov 2, 2022 · 9 comments
Assignees
Labels
P2 Priority: Medium

Comments

@SamYeh
Copy link

SamYeh commented Nov 2, 2022

Describe the bug
When a measure has both a right repeat sign and a section break, followed by more or measures, the pause for the section break is included in the repeat.

To Reproduce
image
Play and observe that there is a 3-second pause after the first two bars have been played once.

Expected behavior
The first two bars should be played twice without pause in between.

Platform information

  • OS: Windows 11
  • Build: Build: MuseScoreNightly-202211010451-master-97bad50-x86_64
@DaddyLudwig
Copy link

I’m pretty sure this has always been the case. I myself have to do one of 2 things for this, those being:

  1. Set pause to 0 for section break(like if I have repeats and attaca)
  2. Place the section break one measure after the repeat and set the measure invisible in measure properties(like in the development and recapitulation repeat of a Mozart Sonata)

@SamYeh
Copy link
Author

SamYeh commented Nov 2, 2022

But is that the expected behavior, though?

@DaddyLudwig
Copy link

I’d say yes because it was like this in 3.6 and I’ve never seen talk about changing the behavior of the section break on repeats, just the 2 workarounds for it I mentioned.

@MarcSabatella
Copy link
Contributor

Definitely not intended, but yes, it's a bug in 3.6.2 as well. There have actually been quite a few reports of this and some attempts made at coming up with fixes, but no success yet.

@Tantacrul Tantacrul added this to To do in 4.x LONGLIST via automation Nov 8, 2022
@Tantacrul Tantacrul added this to To do in [MU4 - MPE] via automation Nov 8, 2022
@Tantacrul Tantacrul added the P2 Priority: Medium label Nov 8, 2022
@jeetee
Copy link
Contributor

jeetee commented Jan 25, 2023

As mentioned in https://musescore.org/en/node/32696 I'm willing to try and take this up again now that MPE is starting to settle down. The RepeatList logic already contains some preparation information on when the pause should be applied, but we still need to look into how to tie that information in with the code that generates the playback information (which in MS3 also meant that first the TempoMap needed to be made repeat-aware).

@BanjoJake
Copy link

BanjoJake commented Aug 22, 2023

Also happens using loop playback without repeat bars, if measure ends in a section break.

@adelara
Copy link

adelara commented Mar 1, 2024

Happy Friday, March/1/2024... that bug is still nagging isn't ? I'd think 10 years is a pretty good period to have it figured out... luckily I dont ran into it often, but today, I did - https://musescore.org/en/node/32696

@cbjeukendrup
Copy link
Contributor

Perhaps the newly added TempoMap::pauseSecs can help to fix this issue.

@Jojo-Schmitz
Copy link
Contributor

@jeetee ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
4.x LONGLIST
  
To do
[MU4 - MPE]
  
To do
Development

No branches or pull requests

10 participants