Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Augmentation dot shortcut doesn't work while editing tablature #14574

Closed
BNTVGL opened this issue Nov 17, 2022 · 8 comments · Fixed by #17380
Closed

[MU4 Issue] Augmentation dot shortcut doesn't work while editing tablature #14574

BNTVGL opened this issue Nov 17, 2022 · 8 comments · Fixed by #17380
Assignees
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute guitar Related to guitar notation and user experience for guitarists P2 Priority: Medium regression Regression on a prior release

Comments

@BNTVGL
Copy link

BNTVGL commented Nov 17, 2022

Describe the bug
While in note input mode in a tablature, pressing "." to add augmentation dot does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new sheet with tablature
  2. While in the note input mode, press "." to activate the augmentation dot
  3. See that it remains inactive

Expected behavior
The augmentation dot should activate

Screenshots

2022-11-17.15-38-44.mp4

Platform information
OS: Windows 10 Version 2009, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223200405, revision: github-musescore-musescore-4bd88ed

Additional context
I am using the Nightly version last modified 2022-11-17 04:27, but I've first noticed this issue when I downloaded the open beta.

@Tantacrul Tantacrul added this to To do in Guitar Pro import via automation Nov 22, 2022
@Tantacrul Tantacrul added the P2 Priority: Medium label Nov 22, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Nov 22, 2022
@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute regression Regression on a prior release labels Mar 12, 2023
@daijingz

This comment was marked as outdated.

@daijingz

This comment was marked as outdated.

@deswinteil
Copy link
Contributor

I'm not quite sure how this issue is progressing now,if @daijingz is not solving this problem anymore,Maybe I can try to solve this problem.

@Jojo-Schmitz
Copy link
Contributor

@deswinteil go for it, @daijingz hasn't come back since some 5 weeks

@deswinteil
Copy link
Contributor

@Jojo-Schmitz What I first thought was that the keyboard did not respond successfully in the tab spectrum, but I searched for Qt::Key_Period in the repo but couldn't find it, so I want to know where the operation of pressing . to toggle the dot is implemented

@deswinteil
Copy link
Contributor

Ah ,I think I found it, actually it's pad_dot

@rgreen5
Copy link

rgreen5 commented Sep 9, 2023

OS: Linux Mint 20.1, Arch.: x86_64, MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Bug still extant in the latest version. Could this be fixed for MS 4.2?

@cbjeukendrup cbjeukendrup removed this from To do in Guitar Pro import Sep 9, 2023
@cbjeukendrup cbjeukendrup removed this from In progress in 4.x SHORTLIST Sep 9, 2023
@cbjeukendrup cbjeukendrup added the guitar Related to guitar notation and user experience for guitarists label Sep 9, 2023
@cbjeukendrup
Copy link
Contributor

Could this be fixed for MS 4.2?

You're lucky, it turns out that someone had already contributed a fix that looks good! So that will likely be merged to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute guitar Related to guitar notation and user experience for guitarists P2 Priority: Medium regression Regression on a prior release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants