Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Task] Add 'Beam type' to Properties panel for rests #15446

Closed
oktophonie opened this issue Dec 20, 2022 · 6 comments
Closed

[MU4 Task] Add 'Beam type' to Properties panel for rests #15446

oktophonie opened this issue Dec 20, 2022 · 6 comments
Assignees
Labels
needs design Design is needed P1 Priority: High

Comments

@oktophonie
Copy link
Contributor

Task description
The properties panel has a 'Beam type' section for Notes:
image

This should be added for Rests too. At the moment, only the 'Beam properties' palette can be used to apply these to rests.
For notes, one can consult the properties panel to see which 'beam type' has been applied to a note, but one cannot do this for rests.

(I can't shake the feeling that there's already an issue/task for this but I can't seem to find it. If anyone does, close this one and shout at me.)

@oktophonie oktophonie added the needs design Design is needed label Dec 20, 2022
@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Dec 20, 2022

In MU4 the rests don't have any specific section for them in Properties, whereas in MU3 they have a section that only contains the "Small" option, but I guess that's covered more consistently in MU4. So this here seems to need the design for a new "Rest" section for Properties? Can't think of anything else though that might need to go in that section besides reusing the "Beam type" panel there.

@Harmoniker1
Copy link
Contributor

Harmoniker1 commented Dec 20, 2022

image

I played with this for a while and saw that if I select both the first note and the first rest here, setting the beam mode in Properties would make the note's beam mode change, but not the rest's, so I went into the code and added one line that made the rest's beam mode able to change, but still if I only select the rest, there isn't any setting in Properties.

It can definitely be fixed by adding a "Rest" section, in which the "Beam type" panel is reused, but then there's the question of whether or not the "Rest" section is shown when there're both note(s) and rest(s) selected, since the one single setting available in "Rest" is already covered in the "Note" section. It's one option to just show the "Note" section, and only show "Rest" if no notes are selected, but if in some cases it might be desired to set the beam mode of notes and rests separately (is it?), the two sections should still both appear.

Anyway, I may seem overzealous about this, if so, I apologise, but I think either way, I would be able to work on this issue.

@Tantacrul Tantacrul added the P1 Priority: High label Dec 21, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Dec 21, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - INSPECTOR] via automation Dec 21, 2022
@bkunda
Copy link

bkunda commented Jan 6, 2023

there's the question of whether or not the "Rest" section is shown when there're both note(s) and rest(s) selected

We already have a design solution for this, which is to show buttons for each property type when more than one different element is selected.

Screenshot 2023-01-06 at 2 43 22 pm

So I think we fall back on this in adding a new properties section for "rests".

The fact that you can only open one of these popups at a time should hopefully allay any confusion concerning the adjustment of beaming for either notes or rests (because you can only do either one of these at a time).

Personally, I think a dedicated "rests" section makes sense here, because it seems intuitive to want to modify a beam over a rest by first selecting the rest.

@oktophonie can you think of any other properties we might need for rests? I might give this one a go now.

@bkunda
Copy link

bkunda commented Jan 6, 2023

(I can't shake the feeling that there's already an issue/task for this but I can't seem to find it. If anyone does, close this one and shout at me.)

@oktophonie was this the task you were thinking of? #9892
I was certainly reminded of it. This was to add an option for "beam end".

@oktophonie
Copy link
Contributor Author

@bkunda For now, not that immediately springs to mind; but when we get to implementing stemlets it would make sense for control(s) for those to live under Rest -> Beam too.

@oktophonie
Copy link
Contributor Author

Closing as subsumed by #15779

@oktophonie oktophonie closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
[MU4.0 - INSPECTOR] automation moved this from To do to Done Feb 23, 2023
4.x SHORTLIST automation moved this from To do to Done Feb 23, 2023
@oktophonie oktophonie removed this from Done in 4.x SHORTLIST Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design Design is needed P1 Priority: High
Projects
No open projects
Development

No branches or pull requests

4 participants