-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Task] Add 'Beam type' to Properties panel for rests #15446
Comments
In MU4 the rests don't have any specific section for them in Properties, whereas in MU3 they have a section that only contains the "Small" option, but I guess that's covered more consistently in MU4. So this here seems to need the design for a new "Rest" section for Properties? Can't think of anything else though that might need to go in that section besides reusing the "Beam type" panel there. |
I played with this for a while and saw that if I select both the first note and the first rest here, setting the beam mode in Properties would make the note's beam mode change, but not the rest's, so I went into the code and added one line that made the rest's beam mode able to change, but still if I only select the rest, there isn't any setting in Properties. It can definitely be fixed by adding a "Rest" section, in which the "Beam type" panel is reused, but then there's the question of whether or not the "Rest" section is shown when there're both note(s) and rest(s) selected, since the one single setting available in "Rest" is already covered in the "Note" section. It's one option to just show the "Note" section, and only show "Rest" if no notes are selected, but if in some cases it might be desired to set the beam mode of notes and rests separately (is it?), the two sections should still both appear. Anyway, I may seem overzealous about this, if so, I apologise, but I think either way, I would be able to work on this issue. |
We already have a design solution for this, which is to show buttons for each property type when more than one different element is selected. So I think we fall back on this in adding a new properties section for "rests". The fact that you can only open one of these popups at a time should hopefully allay any confusion concerning the adjustment of beaming for either notes or rests (because you can only do either one of these at a time). Personally, I think a dedicated "rests" section makes sense here, because it seems intuitive to want to modify a beam over a rest by first selecting the rest. @oktophonie can you think of any other properties we might need for rests? I might give this one a go now. |
@oktophonie was this the task you were thinking of? #9892 |
@bkunda For now, not that immediately springs to mind; but when we get to implementing stemlets it would make sense for control(s) for those to live under Rest -> Beam too. |
Closing as subsumed by #15779 |
Task description
![image](https://user-images.githubusercontent.com/20604032/208718559-78e9c395-7bba-483e-b49b-636e0e2b9d0e.png)
The properties panel has a 'Beam type' section for Notes:
This should be added for Rests too. At the moment, only the 'Beam properties' palette can be used to apply these to rests.
For notes, one can consult the properties panel to see which 'beam type' has been applied to a note, but one cannot do this for rests.
(I can't shake the feeling that there's already an issue/task for this but I can't seem to find it. If anyone does, close this one and shout at me.)
The text was updated successfully, but these errors were encountered: