Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default folder is still created despite new preferences #15567

Closed
KimHono opened this issue Dec 24, 2022 · 8 comments · Fixed by #17942
Closed

Default folder is still created despite new preferences #15567

KimHono opened this issue Dec 24, 2022 · 8 comments · Fixed by #17942
Assignees
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium

Comments

@KimHono
Copy link

KimHono commented Dec 24, 2022

Describe the bug
I wanted to get rid of the default folder ~/Documents/MuseScore4 created each time I launch the software.
So in Edit>Preferences, I modified the folder path, and moved the default files in the new folder.
But after restarting, the default folder is one more time created in ~/Documents/ !
Curiously, if I check the preferences, my choices are those awaited.

To Reproduce
Steps to reproduce the behavior:

  1. Copy ~/Documents/MuseScore4 in another place
  2. Start MuseScore 4
  3. In menu Edit>Preferences, select the new path everywhere;
  4. Stop MuseScore 4
  5. Delete ~/Documents/MuseScore4
  6. Start MuseScore 4

Expected behavior
~/Documents/ may never more include the MuseScore4 folder

Platform information

  • OS: Linux Arch 6.0.12-arch1-1

Additional context

  • MuseScore 4.0.0
@aecati
Copy link

aecati commented May 20, 2023

This bug has been discussed here, too: https://musescore.org/en/node/335161

It is the only reason, I don`t use MuseScore 4, even it has great improvements. This bug destroys my backups.

@KimHono
Copy link
Author

KimHono commented May 21, 2023

Thanks @aecati for this link !
This bug is annoying, but on the other hand MuseScore is working well, except the mixer sometimes. So I've been using version 4 since it's release.

@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium labels May 21, 2023
@cbjeukendrup cbjeukendrup added this to To do in 4.x SHORTLIST via automation May 21, 2023
@cbjeukendrup cbjeukendrup removed this from To do in 4.x SHORTLIST May 21, 2023
@707ryanmckay707
Copy link
Contributor

Hi, I'd like to work on this issue, and it looks like the standard practice is to ask someone to be assigned to it. Could I be assigned to this issue? It would be my first one, and I'm excited to give it a shot!

@707ryanmckay707
Copy link
Contributor

707ryanmckay707 commented Jun 7, 2023

Hi, so while working on this issue, I found another issue, #15264, which is a sub problem, for fixing this bug. So I wanted to share it incase you wanted to close it or assign it to me etc.

So far I've fixed the Scores, Styles, Templates, Plugins and Soundfont subfolders from auto generating, with them now only generating at startup if the user hasn't set a custom location. Once I've fixed all the sub folders from autogenerating, then the MuseScore4 Documents folder itself will be fixed from autogenerating. The Cloud Scores and VST3 subfolders are the two main ones that I have left to do.

To fix the Cloud Scores subfolder from autogenerating, the user needs to have the option to change that folder location as well, so I'm planning to add that option to Folder Preferences window, as long as that's okay! (This would solve issue #15264)

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Jun 7, 2023

Don't worry about the cloud scores folder; I am currently working on a PR where the cloud scores folder will be moved to a more hidden user data location. So for now, you can just disable the automatic creation of this folder, but better not make it customisable.

@cbjeukendrup
Copy link
Contributor

Thanks for the heads-up about that other issue, by the way! I've closed it as a duplicate.

@707ryanmckay707
Copy link
Contributor

Cool thanks, and no problem!

@707ryanmckay707
Copy link
Contributor

707ryanmckay707 commented Jun 12, 2023

Hi so I submitted my pull request! Here's just a couple notes:

To fix the Scores folder specifically, I had to do additional changes compared to other 4 fixed folders, so I included extra details on what the changes were to help with the review process. Also, the changes which made fixing the Scores folder possible, fixed the bug where the default Scores path was not displaying in the Folder Preferences window (This didn't come from changing any QML code, but instead from fixing the Settings::Key value it was pulling from for display).

Also, there was one small additional bug I found, in the same location that I was implementing part of my fix, so I included it in this pull request, just in case you also wanted it as well. I'm happy to remove that extra bug fix and make any other changes as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants