Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties > Fret diagrams: when applying scale value to style, in fact 100x the scale value is applied to style #15752

Closed
cbjeukendrup opened this issue Jan 8, 2023 · 2 comments
Closed

Properties > Fret diagrams: when applying scale value to style, in fact 100x the scale value is applied to style #15752

cbjeukendrup opened this issue Jan 8, 2023 · 2 comments
Assignees
@cbjeukendrup
Labels
needs testing Testing is needed (if issue doesn't reproduce or might be fixed already) P2 Priority: Medium properties
Projects
MuseScore 4.1

Comments

@cbjeukendrup
Copy link
Contributor

Describe the bug
In the Inspector, in some cases, there is a conversion between the value displayed in the UI and the internal value. For example, a scale value is internally stored as a real number, but in the UI presented as a percentage. But today, while digging in the code, I found something strange: this conversion is not applied when applying the current value to style. This results for example in the following bug:

To Reproduce
Steps to reproduce the behavior:

  1. Create score
  2. Add fret diagram
  3. In Properties > Settings, change scale
  4. Apply to style
    -> Boom

Screenshots

Schermopname.2023-01-08.om.01.37.38.mov

Additional context
This was simply the first example I found, but this may very well apply to other elements and properties too; maybe with even more janky results.
@cbjeukendrup cbjeukendrup self-assigned this Jan 8, 2023
@cbjeukendrup cbjeukendrup mentioned this issue Jan 8, 2023
Draft
@cbjeukendrup cbjeukendrup added the P2 Priority: Medium label Feb 16, 2023
@cbjeukendrup cbjeukendrup added this to To do in [MU4.0 - INSPECTOR] via automation Feb 16, 2023
@cbjeukendrup cbjeukendrup added this to To do in 4.x SHORTLIST via automation Feb 16, 2023
@oktophonie oktophonie added this to To triage in MuseScore 4.1 via automation Feb 27, 2023
@oktophonie oktophonie removed this from To do in 4.x SHORTLIST Feb 27, 2023
@RomanPudashkin RomanPudashkin moved this from To triage to In Progress in MuseScore 4.1 Mar 1, 2023
@oktophonie oktophonie changed the title [MU4 Issue] Inspector > Fret diagrams: when applying scale value to style, in fact 100x the scale value is applied to style Properties > Fret diagrams: when applying scale value to style, in fact 100x the scale value is applied to style Jul 28, 2023
@oktophonie oktophonie removed this from To do in [MU4.0 - INSPECTOR] Jul 28, 2023
@cbjeukendrup
Copy link
Contributor Author

It seems this has been fixed (by e6457fb). @DmitryArefiev or @zacjansheski could one of you confirm that? (retesting in 4.2 build should be enough)

@cbjeukendrup cbjeukendrup added the needs testing Testing is needed (if issue doesn't reproduce or might be fixed already) label Dec 12, 2023
@zacjansheski
Copy link
Contributor

Fixed in 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbjeukendrup cbjeukendrup

Labels
needs testing Testing is needed (if issue doesn't reproduce or might be fixed already) P2 Priority: Medium properties
Projects
MuseScore 4.2
Status: Done
MuseScore 4.1
  
In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oktophonie @cbjeukendrup @zacjansheski