Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuseScore freezes/crashes when Palm Mute has no beginning #17622

Closed
xlaech opened this issue May 18, 2023 · 1 comment · Fixed by #17682
Closed

MuseScore freezes/crashes when Palm Mute has no beginning #17622

xlaech opened this issue May 18, 2023 · 1 comment · Fixed by #17682
Assignees
Labels
crash Issues involving a crash of MuseScore P1 Priority: High

Comments

@xlaech
Copy link

xlaech commented May 18, 2023

Issue type

Crash or freeze

Bug description

When removing notes that had palm mute to them applied without removing the palm mute, the program freezes and needs to be manually stopped as soon as one tries to change the remaining Palm Mute. My guess would be, that the beginning of the palm mute is not reset resulting in something like a nullpointer exception.

I tried to create an example file, but when I save the broken file and reopen the file, the PM gets removed - either the save or the load process seems to be aware of this oddity and removes the "underdefined" palm mute.

Steps to reproduce

  1. Create 2 bars of notes
  2. Add a palm mute that starts on the last note in the first bar, but continues into the second bar
  3. Remove all notes in the first bar
  4. Select the remaining palm mute
  5. Try to drag it to the remaining bar => crash

Screenshots/Screen recordings

Basic Setup:
I - Basic Setup

Selecting the first bar
II - Select First bar

Removing the first bar
This will keep the palm mute, which makes sense, since it still it needed for the second bar. However we can already see, that the beginning seems to be set incorrectly.
III - remove will keep PM

Changing the PM
My cursor is not shown in this screenshot, but selecting is no issue, but as soon as I try to change the PM e.g. by dragging muse score freezes.
IV - changing remaining PM crash

MuseScore Version

4.0.2

Regression

I don't know

Operating system

macOS 12.06

Additional context

No response

@muse-bot muse-bot added the crash Issues involving a crash of MuseScore label May 18, 2023
@bkunda bkunda assigned mike-spa and unassigned RomanPudashkin May 19, 2023
@bkunda bkunda added the P1 Priority: High label May 19, 2023
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 22, 2023

FWIW: 3.x apparently is not affected by this bug (at least I can't reproduce it there), so it seems to be a regression.
But it has very similar code to that from #17682 in at least LetRing::linePos() and PalmMute::linePos().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Issues involving a crash of MuseScore P1 Priority: High
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants