Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert (debug-mode only) when changing measure properties #17869

Open
Jojo-Schmitz opened this issue Jun 6, 2023 · 2 comments
Open

Assert (debug-mode only) when changing measure properties #17869

Jojo-Schmitz opened this issue Jun 6, 2023 · 2 comments
Assignees

Comments

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jun 6, 2023

Issue type

Crash or freeze

Bug description

No response

Steps to reproduce

  1. Open attached score (WIP.zip) or create a score from scratch
  2. Right-click into measure 8 of the above score or any measure
  3. Select Measure properties
  4. Change the play count (of the above score) or any other poperty
  5. Press OK or Apply

--> Crash!

Screenshots/Screen recordings

"Famous last words" in the logs:

2023-06-06T13:38:48.425 | INFO  | main_thread | ActionsDispatcher | dispatch: try call action: measure-properties
2023-06-06T13:38:48.471 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:38:48.493 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:38:48.549 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:38:48.663 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:38:52.651 | DEBUG | main_thread | Score      | endCmd: Undo stack current macro child count: 1
2023-06-06T13:38:52.656 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:38:52.658 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:38:52.661 | ERROR | main_thread | InteractiveProvider | topWindow: "ASSERT FAILED!": Window must have a parent!, file: C:/Users/Jojo/Documents/GitHub/MuseScore/src/framework/ui/view/interactiveprovider.cpp, line: 479

So it dies of a failed assertion...

    if (!last.window->parent()) {
        ASSERT_X("Window must have a parent!");
    }

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.0) (Self built from latest master code, in Debug and in RelWithDebInfo mode)

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Windows 11

Additional context

Commenting out that ASSERT_X() prevents that crash (unsurprisingly) and (to my siuprise) doesn't seem to have any ill effect.

Logs:

2023-06-06T13:50:19.727 | DEBUG | main_thread | Score      | endCmd: Undo stack current macro child count: 1
2023-06-06T13:50:19.731 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:50:19.734 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown
2023-06-06T13:50:19.748 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:50:23.439 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:50:23.963 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:50:24.428 | WARN  | main_thread | Qt         | QQmlComponent: Created graphical object was not placed in the graphics scene.
2023-06-06T13:50:24.528 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationOpened
2023-06-06T13:50:26.364 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:50:26.460 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationFocused
2023-06-06T13:52:36.681 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationOpened
2023-06-06T13:52:36.683 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxNotationOpened
2023-06-06T13:52:36.686 | DEBUG | main_thread | UiActionsRegister | updateEnabledAll: currentCtx: UiCtxUnknown

That ASSERT_X() came in with #16132 to fix #15171

@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression Regression on a prior release labels Jun 6, 2023
@Jojo-Schmitz Jojo-Schmitz changed the title Crash when change measure prpperty's play count Crash when change measure property's play count Jun 6, 2023
@Jojo-Schmitz Jojo-Schmitz changed the title Crash when change measure property's play count Crash when changing measure property's play count Jun 6, 2023
@Jojo-Schmitz Jojo-Schmitz changed the title Crash when changing measure property's play count Crash when changing measure properties Jun 6, 2023
@bkunda bkunda added the needs info More information is required before action can be taken label Jun 7, 2023
@zacjansheski

This comment was marked as resolved.

@Jojo-Schmitz

This comment was marked as resolved.

@RomanPudashkin RomanPudashkin changed the title Crash when changing measure properties Assert (debug-mode only) when changing measure properties Jun 12, 2023
@RomanPudashkin RomanPudashkin removed regression Regression on a prior release crash Issues involving a crash of MuseScore needs info More information is required before action can be taken labels Jun 12, 2023
@RomanPudashkin RomanPudashkin added this to To do in 4.x LONGLIST via automation Jun 12, 2023
@RomanPudashkin RomanPudashkin self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.x LONGLIST
  
To do
Development

No branches or pull requests

6 participants