New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding expression text to multimeasure rest shouldn't break it #18969
Comments
I'd say that's a matter of opinion. |
Yeah, agree |
As long as it's just expression text that breaks mmrests and not staff or tempo text or rehearsal marks (and indeed this is true), I could buy into calling this a feature... |
Or rather the converse surely; expression doesn't break, staff, tempo rehearsal marks do break. |
I think you are thinking of a different sense of "break" than what I see in this issue. "Exclude" is actually more like it. That is, currently in 4.1.1, an expression text on a measure cause the measure to not be eligible for inclusion in an mmrest at all. Whereas other text will break the mmrest but not exclude the measure from inclusion. So, right now, if you start with this: It turns into this: The behavior for the staff text is absolutely correct - it breaks but doesn't exclude. But the expression text - a new element type for 4.1 - does something different. Probably it should be handled the same as staff text, but that's what's a matter of opinion. |
So really this is a regression on 4.0 rather than 3.x. While there may be a question about what expression text on a multirest actually means, the sensible thing for now is just to return it back to how it was. |
Fixed in #19001 |
Issue type
Engraving bug
Steps to reproduce
bandicam.2023-08-08.17-10-53-957.mp4
MuseScore Version
4.2.0 master
Regression
Yes, this used to work in MuseScore 3.x and now is broken
Operating system
Windows10
Additional context
#18919
The text was updated successfully, but these errors were encountered: