Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding expression text to multimeasure rest shouldn't break it #18969

Closed
DmitryArefiev opened this issue Aug 8, 2023 · 7 comments · Fixed by #19001
Closed

Adding expression text to multimeasure rest shouldn't break it #18969

DmitryArefiev opened this issue Aug 8, 2023 · 7 comments · Fixed by #19001
Assignees
Labels
engraving P2 Priority: Medium regression Regression on a prior release

Comments

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Aug 8, 2023

Issue type

Engraving bug

Steps to reproduce

bandicam.2023-08-08.17-10-53-957.mp4

MuseScore Version

4.2.0 master

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows10

Additional context

#18919

@muse-bot muse-bot added engraving regression_ms3 Regression from MS3 (3.6.2) labels Aug 8, 2023
@DmitryArefiev DmitryArefiev assigned Eism and unassigned oktophonie Aug 8, 2023
@DmitryArefiev DmitryArefiev added the P2 Priority: Medium label Aug 8, 2023
@oktophonie
Copy link
Contributor

I'd say that's a matter of opinion.

@DmitryArefiev
Copy link
Contributor Author

Yeah, agree

@MarcSabatella
Copy link
Contributor

As long as it's just expression text that breaks mmrests and not staff or tempo text or rehearsal marks (and indeed this is true), I could buy into calling this a feature...

@SteveBlower
Copy link

Or rather the converse surely; expression doesn't break, staff, tempo rehearsal marks do break.

@MarcSabatella
Copy link
Contributor

I think you are thinking of a different sense of "break" than what I see in this issue. "Exclude" is actually more like it. That is, currently in 4.1.1, an expression text on a measure cause the measure to not be eligible for inclusion in an mmrest at all. Whereas other text will break the mmrest but not exclude the measure from inclusion.

So, right now, if you start with this:

image

It turns into this:

image

The behavior for the staff text is absolutely correct - it breaks but doesn't exclude. But the expression text - a new element type for 4.1 - does something different. Probably it should be handled the same as staff text, but that's what's a matter of opinion.

@oktophonie oktophonie added regression Regression on a prior release and removed regression_ms3 Regression from MS3 (3.6.2) labels Aug 9, 2023
@oktophonie oktophonie assigned oktophonie and mike-spa and unassigned Eism Aug 9, 2023
@oktophonie
Copy link
Contributor

So really this is a regression on 4.0 rather than 3.x. While there may be a question about what expression text on a multirest actually means, the sensible thing for now is just to return it back to how it was.

@DmitryArefiev
Copy link
Contributor Author

Fixed in #19001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium regression Regression on a prior release
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants