Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Header text positioning, adds space consuming gap unexpectedly reducing the available music area #19014

Closed
HeinzVo opened this issue Aug 10, 2023 · 5 comments
Assignees
Labels
by design The behaviour is intentional. It's not a bug; it's a feature! engraving P3 Priority: Low regression_ms3 Regression from MS3 (3.6.2) UI Visual issues affecting the UI (not notation)

Comments

@HeinzVo
Copy link

HeinzVo commented Aug 10, 2023

Issue type

UI bug

Bug description

Bad Header text positioning, adds space consuming gap, thus unexpectedly reducing the usable music area.

Placing Header text ABOVE the top page margin is NOT POSSIBLE without loosing rare page space at the music area,
while placing Footer text BELOW the bottom page margin perfectly works with no interaction at the music part.
This inconsistency between Header and Footer should be removed!

At header text (Format / Style / Text Stiles / Header) positive and negative offsets both add a useless gap, unexpectedly limiting and shifting down the music area.
At footer text (Format / Style / Text Stiles / Footer) positive and negative offsets (referred to page margin) work fine as expected, not clipping the music part.

Header features should be well harmonized with Footer to achive full and free positioning control without influencing, reducing or shifting the music area.
Also swiching Headers and Footers on/off should NOT influence the music area or score page rendering (as worked excellent in MS 3.6.2).

Steps to reproduce

At header text (Format / Style / Text Stiles / Header) positive and negative offsets both add a useless gap, unexpectedly limiting and shifting down the music area.

At footer text (Format / Style / Text Stiles / Footer) positive and negative offsets (referred to page margin) work fine as expected, not clipping the music part.

Test score and screenshots included inside following zip:
Detected Problems MuseScore-4.X.X.zip

Screenshots/Screen recordings

MuseScore 4_Style_Header_off (mark)
MuseScore 4_Style_Header_2mm (mark)
MuseScore 4_Style_Header_-3mm (mark)
MuseScore 4_Style_Footer_off (mark)
MuseScore 4_Style_Footer_-1mm (mark)
MuseScore 4_Style_Footer_3mm (mark)

MuseScore Version

MuseScore 4 (any version)

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows10 and 11, 64-bit

Additional context

No response

@muse-bot muse-bot added regression_ms3 Regression from MS3 (3.6.2) UI Visual issues affecting the UI (not notation) labels Aug 10, 2023
@oktophonie oktophonie self-assigned this Aug 11, 2023
@MarcSabatella
Copy link
Contributor

MarcSabatella commented Aug 11, 2023

It seems to me there is a bug here, but there is also a misunderstanding about the new design. Headers no longer "steal" space from the score as they did in MU3. So you no longer need the old hack of applying a negative offset to the header text style to force the header into the marign area just to avoid collisions, nor do you need to artifically increase the margin size to account for this header. Just set the margin to the actual amount of white space you desire, and leave the header offset at the default.

However, it does appear there is a bug in the algorithm that calculates the amount of space required for header. As shown in the example, the space is reserved for the header even it ends up not being needed because the header text itself has been shifted upwards, and in fact the amount of space reserved actually increases when offseting the text in this manner.

So in the following example:

image

The text in the score runs right up to the top margin. If I add a header using the defaults, it correctly adds space:

image

However, rather than decreasing the space if the header text itself is moved into the margin (via negative offset in the text style), MuseScore actually increases the amount of space required:

image

@oktophonie oktophonie added by design The behaviour is intentional. It's not a bug; it's a feature! P3 Priority: Low labels Aug 11, 2023
@oktophonie oktophonie added this to To do in 4.x LONGLIST via automation Aug 11, 2023
@oktophonie
Copy link
Contributor

I'll grant that the behaviour of offsetting header text downwards is inconsistent with offsetting footer text upwards.

However, why you'd do this anyway is bizarre. Margins are supposed to be empty (that's what they are for); the header and footer text are part of the page image and do not encroach upon the margins. If you want your header higher or your footer lower you can adjust the top/bottom margins accordingly.

See #9193, and also #17201.

@HeinzVo
Copy link
Author

HeinzVo commented Sep 12, 2023

No. Headers and footers are usually placed fully outside the page-content-margins (see Microsoft-Word or every similar apps). Headers and footers are "optional additional information", NOT belonging to the real page-content (e.g. copyrights or references or page numbers). Only that way it is possible to optional switch on/off the headers/footers without always corrupting the whole page-content-layout.
Also headers and footers could only be present on some pages (e.g. not on the first page) and therefore it's unpractical or completely nonsense to adjust the page-content-margins all the time or for different pages when selecting or unselecting them. So the behavior in MuseScore 3.6.2 should be the correct way and equals to most other text- or graphics-app.

@HeinzVo HeinzVo closed this as completed Sep 12, 2023
4.x LONGLIST automation moved this from To do to Done Sep 12, 2023
@MarcSabatella
Copy link
Contributor

MU3 allows headers to collide directly with the page content, or to encroach upon the margin and even extend right off the page. Neither is even remotely acceptable. No other program does any such thing - all programs I know, including Word, allocate space for headers as needed. Meaning yes, as your header grows in size, it will push content off the page. This is trivial to demonstrate for yourself in Word.

@HeinzVo
Copy link
Author

HeinzVo commented Sep 12, 2023

Then the positioning should be limited in a way that it lies always inside the page but outside the defined contents-margins. See at Microsoft Word how it does this correctly. Headers and contents have different limits/sizes usually not influencing each other, when properly set to not overlap.

@musescore musescore locked and limited conversation to collaborators Sep 12, 2023
@cbjeukendrup cbjeukendrup removed this from Done in 4.x LONGLIST Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by design The behaviour is intentional. It's not a bug; it's a feature! engraving P3 Priority: Low regression_ms3 Regression from MS3 (3.6.2) UI Visual issues affecting the UI (not notation)
Projects
None yet
Development

No branches or pull requests

5 participants