Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth panning (auto-scrolling) should work as good as in MS3.6.2 #19210

Open
DmitryArefiev opened this issue Aug 29, 2023 · 4 comments
Open
Labels
needs design Design is needed P2 Priority: Medium regression_ms3 Regression from MS3 (3.6.2)

Comments

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Aug 29, 2023

Bug description

Smooth panning (auto-scrolling) should work as good as in MS3.6.2 (or better)

Steps to reproduce

See #19169 (comment)

Screenshots/Screen recordings

263736995-de98b124-a341-4240-ae11-ddeabe003561.mp4

MuseScore Version

4.2.0 master

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

All

Additional context

#18718

@muse-bot muse-bot added the regression_ms3 Regression from MS3 (3.6.2) label Aug 29, 2023
@DmitryArefiev DmitryArefiev added the P1 Priority: High label Aug 29, 2023
@DmitryArefiev DmitryArefiev self-assigned this Aug 29, 2023
@bkunda bkunda added P3 Priority: Low and removed P1 Priority: High labels Aug 29, 2023
@bkunda
Copy link

bkunda commented Aug 29, 2023

Not sure I agree this is a P1, especially given the mountain of other issues we have in the 4.2 project.
I understand though that this feature has been recently brought "back in" to v.4, and it's obviously the case that it needs improving to make it function as well as it did in v.3 (if not better).
So this will take some time, and there also needs to be a bit of design work around the labelling of the feature and choosing where else to expose it.
I'm of the opinion that there are bigger problems to tackle first, hence I've lowered the priority but kept it in the project.

@DmitryArefiev DmitryArefiev changed the title Smooth panning (auto-scrolling) should work as good as in MS3.6.2 (or better) Smooth panning (auto-scrolling) should work as good as in MS3.6.2 Aug 29, 2023
@DmitryArefiev DmitryArefiev removed their assignment Aug 29, 2023
@shoogle
Copy link
Contributor

shoogle commented Aug 30, 2023

Another improvement would be to always position the playback cursor near the left edge of the screen (maybe 1/4 of the way in). It's more valuable to see the music that is coming than the music that has already been played.

@MarcSabatella
Copy link
Contributor

I concur. That should be a trivial change (possibly just changing "2" to "4" in both places here: https://github.com/musescore/MuseScore/pull/18718/files#diff-1ad85d6753e0a807acd0537fa45ee920e557f46ba99c86331e045fd37bec36abR865-R872) that should make it more in line with what's expected.

@asmason
Copy link

asmason commented Sep 29, 2023

The way this worked in MS 3.6.2 was already perfect for my use case (choir practice videos). I'd also say that the implementation of smooth panning was better than any other tool available (Finale, Sibelius, Dorico, etc), for the purpose of recording your screen whilst playing back. The MS 3.6.2 smoothPan advanced preferences allow you some control of position the playhead too, and the scrolling is smooth. The current MS4.2-master implementation seems to jump at the start of each bar. I for one would really appreciate this feature working as it did in MS 3.6.2!

@DmitryArefiev DmitryArefiev added P2 Priority: Medium and removed P3 Priority: Low labels Nov 8, 2023
@bkunda bkunda added the needs design Design is needed label May 15, 2024
@bkunda bkunda added this to To do in 4.x SHORTLIST via automation May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design Design is needed P2 Priority: Medium regression_ms3 Regression from MS3 (3.6.2)
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

6 participants