Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt6 migration] 4.0.0 doesn't see user plugins #21659

Closed
DmitryArefiev opened this issue Feb 23, 2024 · 4 comments
Closed

[Qt6 migration] 4.0.0 doesn't see user plugins #21659

DmitryArefiev opened this issue Feb 23, 2024 · 4 comments
Assignees
Labels
needs design Design is needed needs info More information is required before action can be taken P1 Priority: High regression MS4 Regression on a prior release

Comments

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Feb 23, 2024

Steps to reproduce

  1. Add
    abc_import-4.0.0.zip
    batch_export-master.zip to c:\Users_user name_\Documents\MuseScore4Development\Plugins\
  2. Run MuseScore

Screenshots/Screen recordings

bandicam.2024-02-23.18-02-56-875.mp4

MuseScore Version

4.4.0

Regression

Yes, this used to work in MuseScore 4.3

Operating system

Windows11/Mac13.6

Additional context

No response

@muse-bot muse-bot added the regression MS4 Regression on a prior release label Feb 23, 2024
@DmitryArefiev DmitryArefiev added the P1 Priority: High label Feb 23, 2024
@DmitryArefiev DmitryArefiev changed the title [Qt6 migration] 4.0.0 doesn't see user plugins (Windows) [Qt6 migration] 4.0.0 doesn't see user plugins Feb 23, 2024
@cbjeukendrup
Copy link
Contributor

The reason is that these plugins are not valid for Qt 6; they need to be rewritten. Perhaps, instead of ignoring them completely, we could display these plugins as "invalid", so that the user understands what's going on. Maybe we can even catch the error messages that Qt gives when trying to load these plugins, and somehow convey these to the user, so that the user can try to fix them.

@bkunda bkunda added the needs info More information is required before action can be taken label Feb 27, 2024
@avvvvve avvvvve added the needs design Design is needed label Jun 25, 2024
@bkunda
Copy link

bkunda commented Jul 1, 2024

Okay, so a simple design solution here would be to still show the "invalid" plugins with a reduced opacity, and perhaps a warning sign label.

But at this stage the 0-development solution (preferable from a time POV) though would be just to ensure we have this covered in our documentation. @shoogle could you please add this as an FAQ on the website? (E.g. "Why aren't some of my plugins showing up in MuseScore Studio").

@bkunda bkunda closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2024
@shoogle
Copy link
Contributor

shoogle commented Jul 1, 2024

Note for plugin authors: these commits show the changes required to get plugins working with Qt 6.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jul 2, 2024

The good part is that these 2 plugins never really worked for Mu4, due to #13593/#20822
And won't in Mu4, onless that issue gets fix resp. that PR gets merged...

But these tips don't seem to help much, I can only get a blank window for batch_convert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design Design is needed needs info More information is required before action can be taken P1 Priority: High regression MS4 Regression on a prior release
Projects
Development

No branches or pull requests

8 participants