Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Instrument, part and channel names out of sync and not all stored in save file #21839

Closed
vHeemstra opened this issue Mar 6, 2024 · 5 comments

Comments

@vHeemstra
Copy link

vHeemstra commented Mar 6, 2024

Issue type

Opening/saving issue

Bug description

  1. The part names (orange in screenshot below) are not synced with the instruments names (yellow in screenshot below).
    When renaming an instrument, the part name stays the same.
  2. Part names are not stored in the save file.
    When renaming a part in the Parts dialog, the new name is not stored in the project file.
  3. Part names in Mixer are not in sync with part names in Parts dialog window.
    When you rename a part in the Parts dialog, the new name is not shown correctly in the Mixer window/panel.

Steps to reproduce

  1. Create a new project with an instrument.
  2. Go to Parts dialog/panel and rename the part.
  3. Save the project.
  4. Re-open the project: the part name is reset to the default naming.

Screenshots/Screen recordings

image

MuseScore Version

MuseScore version (64-bit): 4.2.1-240230937, revision: github-musescore-musescore-d757433

Regression

I don't know

Operating system

Windows 10 Version 2009 or later, Arch.: x86_64

Additional context

No response

@vHeemstra
Copy link
Author

So maybe I don't quite understand how the channels in the Mixer are related to the project, but:

  • If they are the instruments, then the should show the instrument's name (currently not in sync after renaming an instrument).
  • If they are the parts, then they are currently not synced after renaming a part.

@vHeemstra vHeemstra changed the title Bug: Instrument and part names out of sync & Renamed parts are not stored in saved file Bug: Instrument, part and channel names out of sync and not all stored in save file Mar 6, 2024
@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Mar 7, 2024

1. The part names (orange in screenshot below) are not synced with the instruments names (yellow in screenshot below).
When renaming an instrument, the part name stays the same.

The things you see in the Instruments panel and the things that you see in the Parts window are not the same. There is in general no one-to-one relation between them, but a many-to-many relation: one Instrument may be printed in multiple Parts (i.e. "part scores"), and a "part score" can contain any number of instruments.

For that reason, the names of the "part scores" are not directly linked to the names of the instruments.
However, we could enhance this in the future, so that if a "part score" contains only one instrument, then the name of that part score follows the name of that instrument by default (but the user can still customise it).


2. Part names are not stored in the save file.
When renaming a part in the Parts dialog, the new name is not stored in the project file.

As far as I can see, this only applies parts that have never been opened yet. This is the result of some technical difficulties that are explained here: #20702 (comment). Solving it would be very non-trivial, unfortunately.


About Mixer channels: I believe these do indeed have their own set of names... this can use some improvement.

@vHeemstra
Copy link
Author

vHeemstra commented Mar 7, 2024

@cbjeukendrup Thank you for the great answer!

Being able to either rename Mixer channels or have them be the instrument names, would be a nice-to-have feature.

@cbjeukendrup
Copy link
Contributor

For the record, I found that there is some duplication between this issue and #15660, #16962, and to some extent #14341 and #19466.
And #21255 might be technically related.

@zacjansheski
Copy link
Contributor

Let's close this and refer to
#16962 (in depth discussion)
and
#14341 (feature request)

@zacjansheski zacjansheski closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants