Style dialog - Enter does not activate OK button, Tab does not move focus to the button group

[MarcSabatella]

Issue type

Accessibility issue (e.g. for keyboard-only or screen reader users)

Bug description

Enter does not operate the OK button in the Style dialog, making it difficult to operate with keyboard only. Alt+O does work on Linux but apparently not on all systems.

Compounding this, the Style dialog is still using the old navigation scheme where Tab moves to the next field instead of the next group. This is actually one of the few dialogs complex enough that really would benefit from the hierarchical navigation. I assume that requires porting to QML, but fixing Enter should be doable as a quick fix.

Worse, the dialog is large enough that it does not fit on some displays, cutting off the visibility of the OK and Cancel buttons. This leads to a lot of people closing via Esc or the "X" on the title bar, then wondering why their changes don't stick.

Steps to reproduce

1. Format / Style
2. Change any style value
3. Press Tab
4. Press Enter

Result: dialog is not closed

5. Press Tab

Result: focus moves to next field instead of to button row

Screenshots/Screen recordings

No response

MuseScore Version

OS: Debian GNU/Linux 12 (bookworm), Arch.: x86_64, MuseScore version (64-bit): 4.2.1-240230938, revision: github-musescore-musescore-d757433

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Debian 12

Additional context

No response

[bkunda]

I am unable to reproduce this on macOS (testing in 4.3).
@zacjansheski do you mind verifying this too?

[zacjansheski]

@bkunda I believe the expectation here is that "Enter" closes the Style window no matter what is selected, that is the behavior in MS3 ("Enter" functions as "OK")

In MS4, "Enter" only works when "OK" or "Cancel" are focused with tab.

[MarcSabatella]

It's been confirmed on Windows too. For Linux, Alt+O works as a mnemonic for OK, but this too does not work on Windows.

As far as I can tell, it's one of the few dialogs with an OK button that cannot be activated by Enter (unless of course you first transfer keyboard focus to that button). The others I found are the Add / Measures dialogs, File / Project properties, and Edit / Preferences. The Preferences dialog at least has better Tab behavior, so it only takes a couple of presses to reach the OK button. The Add / Measures dialog issue is also simple enough to navigate (and is reported separately in #12222). To me the Style dialog is by far the most problematic.

[Jojo-Schmitz]

Came up again in https://musescore.org/en/node/362352#comment-1235309

Esc (and, on Windows, Alt+F4) both work to leave the dialog and dismiss the changes, as if the Cancel button had been pressed, just like it did in Mu3

That dialog by default is 784px high, and as such exceeds our doccumented minmum requirements of "1280x720 pixel resolution, or scaled equivalent".
It is resizable though, unlike the preferenced dialog, but that at least is within limits with a height of 672px