Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal frame and system break prevent courtesy keysigs #22256

Open
SystemsModelling opened this issue Apr 7, 2024 · 24 comments
Open

horizontal frame and system break prevent courtesy keysigs #22256

SystemsModelling opened this issue Apr 7, 2024 · 24 comments
Assignees
Labels
engraving P3 Priority: Low

Comments

@SystemsModelling
Copy link

SystemsModelling commented Apr 7, 2024

Issue type

Engraving bug (incorrect score rendering)

Bug description

Inserting a horizontal frame
and entering a break at that frame breaks the stave all right but now there are no courtesy accidentals

Divisi arrows are beyond RH margin of bars.

image

Entering a break at end bar creates courtesy accidentals, as expected.

image

Suppose we want the divisi arrows to end at the same right hand margin as the rest of the bars?
Instead of entering a system break, inserting a horizontal frame at bar 5 and entering a break at that frame breaks the stave all right but now there are no courtesy accidentals

image

MuseScore Version

MuseScore version (64-bit): 4.2.1-240230937, revision: github-musescore-musescore-d757433

Regression

No

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64

@zacjansheski

This comment was marked as outdated.

@SystemsModelling

This comment was marked as outdated.

@zacjansheski

This comment was marked as outdated.

@Jojo-Schmitz

This comment was marked as outdated.

@SystemsModelling

This comment was marked as outdated.

@Jojo-Schmitz

This comment was marked as outdated.

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Apr 11, 2024

I'm wondering what the best way to solve this would be... A toggle in properties for horizontal frames "Display courtesy keysig, timesig, clef in previous measure" ?

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 11, 2024

I don't think that's needed, it should just work, unconditionally, just as if those frames weren't there.
Only a section break should not display them (unless setup differently, it does have these toggles)

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Apr 11, 2024

Even when the new measure is on the same system? Because there I would argue it shouldn't be the default, but the user should still have control over whether to display it or not

@Jojo-Schmitz
Copy link
Contributor

If the user wants control, (s)he should use a section break

@XiaoMigros
Copy link
Contributor

Section breaks won't work in cases like this...

grafik

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 11, 2024

Ah, indeed not for horizontal frames, I had forgotten about that. They imply a system break.

@XiaoMigros
Copy link
Contributor

Yes, system break on a horizontal frame, which is only one of the many use cases

@Jojo-Schmitz
Copy link
Contributor

But here we're dealing with horizontal frames and system breaks

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Apr 11, 2024

Well, yes. However since there are other instances where different behavior could be wanted, I think a more encompassing solution is best (see my example above)

@iainhallam
Copy link

iainhallam commented Apr 17, 2024

Section breaks won't work in cases like this...

In this case, it seems like you wouldn't want the courtesy key signature, but by default it wouldn't be generated anyway?

@sammik
Copy link
Contributor

sammik commented Apr 17, 2024

I'm wondering what the best way to solve this would be... A toggle in properties for horizontal frames "Display courtesy keysig, timesig, clef in previous measure" ?

I dont think any new option is needed. Option to show / not show courtesy keysig is already included in "normal" key signature.

Problem here is, "previous measure", or "last measure of previous system" is not real measure. So solution would be, to ensure, in creating courtesy keysig, to create them to real measure (skip frames).

Same way, like it does, when frame is at the begining of new system.
courtesy keysig

@XiaoMigros
Copy link
Contributor

XiaoMigros commented Apr 28, 2024

But in cases like this, the user may sometimes want a courtesy and sometimes not. That's why it should be controllable

321551195-9b4bd4b6-c5ac-45ef-891d-852e3d14be56

@sammik

This comment was marked as resolved.

@Jojo-Schmitz

This comment was marked as resolved.

@XiaoMigros

This comment was marked as resolved.

@sammik
Copy link
Contributor

sammik commented Apr 29, 2024

Section breaks won't work in cases like this...

I think, this is different case. I see it as a nice feature request, and original post as a bug.

But if having this nice option, defaults in theese cases should be oposite.

If line break, courtesy keysig should be on, if not line break, courtesy keysig should be off by default. (Of course depending on score style settings too).

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 29, 2024

I wonder whether it is related to #15943/#16530, having the same root cause?

@Jojo-Schmitz
Copy link
Contributor

Isn't this a duplicate of #19759?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P3 Priority: Low
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

8 participants