Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentals probably should not be applied to non-pitched percussion #22713

Open
zacjansheski opened this issue May 7, 2024 · 2 comments
Open
Labels
percussion Pertaining to percussion instruments (notation or playback) UX/interaction

Comments

@zacjansheski
Copy link
Contributor

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

It would be best to disable using accidentals on non-pitched percussion.

Steps to reproduce

  1. Open a score with Drum Kit
  2. In note input mode, use minus to engage the flat accidental
  3. Write a HiHat note, it is triple-flat (no change in playback)

Also you can select a note and then click the accidentals for some general midi fun.

Screenshots/Screen recordings

video1295866651.mp4

MuseScore Version

OS: macOS 14.4, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-241280301, revision: github-musescore-musescore-63d04f9

Regression

No.

Operating system

Mac OS 14

Additional context

No response

@zacjansheski zacjansheski added the percussion Pertaining to percussion instruments (notation or playback) label May 7, 2024
@TeeDeeY
Copy link

TeeDeeY commented May 8, 2024

When I imported some Apple Logic drum parts through MusicXML, there were some accidentals. Attached shows how notes connect to the GM midi standard. I hope MuseScore can expand (instead of limiting) to all of the GM parts, which includes accidentals. Musescore supports most of them.

IMG_7816

The source of the photo is https://support.apple.com/en-gu/guide/logicpro/lgsia2ae90f1/mac

@zacjansheski
Copy link
Contributor Author

@TeeDeeY none of that should, in sheet music that humans read/play, be notated with accidentals. To support import, those midi pitches would need to be mapped on a percussion instrument and properly ID'd. (Most of them are mapped on the "Large Drum kit"). I think a GM kit that supports that specifically would be a feature request that should be logged separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
percussion Pertaining to percussion instruments (notation or playback) UX/interaction
Projects
Status: Issues to fix
Development

No branches or pull requests

3 participants