Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSS crashes when clicking "Close other tabs" on main tab #23489

Closed
krasko78 opened this issue Jul 5, 2024 · 0 comments · Fixed by #23490
Closed

MSS crashes when clicking "Close other tabs" on main tab #23489

krasko78 opened this issue Jul 5, 2024 · 0 comments · Fixed by #23490
Assignees
Labels
crash Issues involving a crash of MuseScore regression Regression on a prior release

Comments

@krasko78
Copy link
Contributor

krasko78 commented Jul 5, 2024

Issue type

Crash or freeze

Bug description

See steps to reproduce.

Steps to reproduce

MSS 4.4 (latest master)

  1. Create a new score (just click Done at the wizard)
  2. Click the Parts button and add a couple of parts or more.
  3. Click "Open all" while the "Parts" dialog is still open.
  4. When all parts open next to the main tab (reading "Untitled score") right-click on it ("Untitled score") and click "Close other tabs" on the context menu.

Actual: MSS crashes.
Expected: MSS closes the other tabs and doesn't crash.

Works fine in 4.3.2.

Screenshots/Screen recordings

No response

MuseScore Version

4.4 (latest master)

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Windows 10

Additional context

The NotationSwitchListModel::closeOtherNotations(int index) function iterates over the other tabs and closes them. Along the way the iteration of the first few notations is fine, but then the iteration results in a null notation and currentMasterNotation()->setExcerptIsOpen(notation, false); blows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Issues involving a crash of MuseScore regression Regression on a prior release
Projects
Development

Successfully merging a pull request may close this issue.

6 participants