Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Task] Improve tooltip descriptions and design #8933

Open
shoogle opened this issue Aug 26, 2021 · 4 comments
Open

[MU4 Task] Improve tooltip descriptions and design #8933

shoogle opened this issue Aug 26, 2021 · 4 comments
Assignees
Labels
P3 Priority: Low

Comments

@shoogle
Copy link
Contributor

shoogle commented Aug 26, 2021

Tooltips are displayed when hovering the cursor over a UI element such as a button.

image

Tooltips can have a:

  • Name
  • Shortcut key combination (optional)
  • Description (optional)

Some of the current names and descriptions are not ideal (e.g. "Note duration: Tie"). Names and descriptions can be edited in the file src/notation/internal/notationuiactions.cpp, possibly without help from the developers.

As discussed with @Tantacrul, we would also like to consider the following changes, which will require developer assistance:

1. Aligning the shortcut (+) to the right of the tooltip like shortcuts in the menus:

image

2. Allowing the description to extend over multiple lines when necessary:

image

Simply allowing it to grow wider is also an option, but we think multiple lines will work better for very long tooltips.

FYI, we often use the tooltip name and description as the "accessible name" and "accessible description" spoken by screen readers, though it is possible to use something else for the screen reader text where necessary.

@shoogle shoogle added the internal Issues for the internal team label Aug 26, 2021
@shoogle shoogle added this to the v4 milestone Aug 26, 2021
@vpereverzev vpereverzev removed this from the v4 milestone Oct 13, 2021
@Tantacrul
Copy link
Contributor

@shoogle - can we close this and move to 4.x safely, do you think?

@shoogle
Copy link
Contributor Author

shoogle commented May 5, 2022

@Tantacrul, I guess this is really two issues:

  1. Align the shortcut on the right.
    • This is a matter of taste really so certainly not urgent.
  2. Prevent clipping of descriptions.
    • This is a bit janky (see screenshot) but it happens rarely and doesn't affect anything functional, so it's your call.

@Tantacrul
Copy link
Contributor

Yeah, I guess that second one needs fixing. Cheers.

@Tantacrul Tantacrul removed the internal Issues for the internal team label May 27, 2022
@Tantacrul
Copy link
Contributor

@bkunda - when you've time, can you spec out the desired design? Then we can post that as a 4.x task. Once done, I'll change this to be a simple bug about tooltips needing to accommodate long strings.

@Tantacrul Tantacrul added the P3 Priority: Low label May 27, 2022
@bkunda bkunda added this to Triage in MS4.X Design Tasks via automation Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low
Projects
No open projects
Development

No branches or pull requests

4 participants