Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Header/footer extends into the margin RFC #9340

Closed
Nick-Mazuk opened this issue Sep 29, 2021 · 1 comment · Fixed by #9193
Closed

[MU4 Issue] Header/footer extends into the margin RFC #9340

Nick-Mazuk opened this issue Sep 29, 2021 · 1 comment · Fixed by #9193
Assignees

Comments

@Nick-Mazuk
Copy link
Contributor

Describe the bug

Currently, the footer is inset into the margin, and the header has the capability of being inset.

Historically, this seems to be the case so headers/footer don't collide with the music. However, with #9193, that will no longer be an issue.

Furthermore, the current behavior may be confusing. In many applications, the margin is considered the printable area (with the exception of headers/footers in Word/Google Docs). So when you set a 1 inch margin, you'd expect the entire score and all the text to be inside that 1 inch area. This is likely the case for many MuseScore users as there are several issues on the MuseScore forum about this very behavior, and even an unmerged PR #5902.

I intend to fix this in #9193 such that the top of the header and bottom of the footer align to the margin. However, I'm creating this issue for comments and suggestions before I update the PR to fix this and before that PR is merged.

Note: this is a breaking change as compared to MuseScore 3, and that is expected. We do know that there will need to be some way to migrate existing scores.

Now to tag users who may be interested in commenting.

@Jojo-Schmitz @MarcSabatella @oktophonie

Additional context

Related:
https://musescore.org/en/node/296528
https://musescore.org/en/node/293201
#9193
#9043
#5902

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 29, 2021

Thanks for the heads-up. Maybe my porting of that PR to 3.x is not feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants