Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] When adding Pedal with asterisk to selection, position of asterisk is unpredictable and often wrong #9975

Open
cbjeukendrup opened this issue Dec 4, 2021 · 2 comments · May be fixed by #20954
Assignees
Labels
engraving P1 Priority: High

Comments

@cbjeukendrup
Copy link
Contributor

Describe the bug
When adding a Pedal with asterisk, the asterisk should appear by default at the very end of the last note of the selection (because that is where the pedal should most likely be raised). It should look like this:
Schermafbeelding 2021-12-04 om 16 50 50
Correct


But most often, when making a selection and clicking the Pedal with asterisk in the Lines palette, the asterisk appears not at the end of the last note, but somewhere just past the start:
Schermafbeelding 2021-12-04 om 16 52 37
Wrong


In some cases, it does appear correctly. As far as I could figure out, that seems to be the case if and only if the selection consists of only the last element of a bar. So if I would select the half note in this example, I would get a correct result:
Schermafbeelding 2021-12-04 om 16 57 50
Correct

This also applies when the bar contains only one item (for example, a whole note or a whole measure rest).


Additional remarks

  • Adding the "Pedal with line" (in contrast to the asterisk variant) seems to produce correct results consistently.

  • When selecting a single note, the pedal will be added from that note to the end of the bar (and the asterisk will be placed incorrectly). I guess this is by design, but we could revise that. This makes it impossible to add a pedal mark to the first half only of a bar in 4/4 that starts with a half note. This also applies to the "Pedal with line" variant.

  • If we want to keep the behaviour mentioned above, I think it should at least take existing pedal marks later inside the bar into account. So it should produce
    Schermafbeelding 2021-12-04 om 17 14 39
    instead of
    Schermafbeelding 2021-12-04 om 17 14 09.

  • When changing the length / duration of a pedal line manually and then making some changes to the music anywhere else, the modified pedal line sometimes jumps vertically. When undoing the changes made to the music anywhere else, the modified pedal line does not jump back, so you need to undo the change to the pedal line too and then redo it manually.


@oktophonie Is all of the above correct in your opinion?

@oktophonie
Copy link
Contributor

This is all excellent in principle and would make it consistent with how hairpins etc work (basically we're saying that if we select (say) three notes, the pedal is to the end of the third note; if we wanted the pedal to come off on the third note, we'd apply it to the first two notes)

There seems to be a magic 'end of note' position that the ends of lines can snap to sometimes though it doesn't seem to work consistently for me, so moving the ends of lines is difficult.

@Tantacrul Tantacrul added P2 Priority: Medium P1 Priority: High and removed P2 Priority: Medium labels May 27, 2022
@Tantacrul Tantacrul added this to To do in 4.x LONGLIST via automation May 27, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - ENGRAVING] via automation May 27, 2022
@Tantacrul

This comment was marked as resolved.

[MU4.0 - ENGRAVING] automation moved this from To do to Done May 27, 2022
4.x LONGLIST automation moved this from To do to Requests May 27, 2022
@oktophonie oktophonie reopened this Jun 13, 2023
4.x LONGLIST automation moved this from Requests to In progress Jun 13, 2023
@oktophonie oktophonie removed this from In progress in 4.x LONGLIST Jun 13, 2023
@oktophonie oktophonie added this to To do in 4.x SHORTLIST via automation Jun 13, 2023
@Theofghy Theofghy linked a pull request Jan 11, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P1 Priority: High
Projects
Status: One of the next releases
Development

Successfully merging a pull request may close this issue.

5 participants