Skip to content

Commit 2a51c5a

Browse files
committed
remove duplicate shortcuts, more capitals
1 parent b2243f0 commit 2a51c5a

File tree

6 files changed

+15
-70
lines changed

6 files changed

+15
-70
lines changed

mscore/actions.cpp

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1940,18 +1940,18 @@ Shortcut Shortcut::sc[] = {
19401940
QT_TRANSLATE_NOOP("action","Layers")
19411941
),
19421942
Shortcut(
1943-
STATE_NORMAL,
1943+
STATE_NORMAL | STATE_NOTE_ENTRY,
19441944
0,
19451945
"next-score",
19461946
Qt::ApplicationShortcut,
1947-
QT_TRANSLATE_NOOP("action","next score")
1947+
QT_TRANSLATE_NOOP("action","Next Score")
19481948
),
19491949
Shortcut(
1950-
STATE_NORMAL,
1950+
STATE_NORMAL | STATE_NOTE_ENTRY,
19511951
0,
19521952
"previous-score",
19531953
Qt::ApplicationShortcut,
1954-
QT_TRANSLATE_NOOP("action","previous score")
1954+
QT_TRANSLATE_NOOP("action","Previous Score")
19551955
),
19561956
Shortcut(
19571957
STATE_INIT | STATE_DISABLED | STATE_NORMAL | STATE_NOTE_ENTRY | STATE_EDIT | STATE_LYRICS_EDIT | STATE_PLAY | STATE_SEARCH | STATE_FOTO,
@@ -1996,18 +1996,6 @@ Shortcut Shortcut::sc[] = {
19961996
"figured-bass",
19971997
QT_TRANSLATE_NOOP("action","Figured Bass")
19981998
),
1999-
Shortcut(
2000-
STATE_NORMAL | STATE_NOTE_ENTRY,
2001-
0,
2002-
"next-score",
2003-
QT_TRANSLATE_NOOP("action","Next Score")
2004-
),
2005-
Shortcut(
2006-
STATE_NORMAL | STATE_NOTE_ENTRY,
2007-
0,
2008-
"prev-score",
2009-
QT_TRANSLATE_NOOP("action","Previous Score")
2010-
),
20111999
Shortcut(
20122000
STATE_NORMAL,
20132001
0,

mscore/album.ui

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<item>
3030
<widget class="QLineEdit" name="albumName">
3131
<property name="toolTip">
32-
<string>album name</string>
32+
<string>Album Name</string>
3333
</property>
3434
</widget>
3535
</item>
@@ -60,7 +60,7 @@
6060
<item row="6" column="1">
6161
<widget class="QPushButton" name="remove">
6262
<property name="toolTip">
63-
<string>remove current score</string>
63+
<string>Remove Current Score</string>
6464
</property>
6565
<property name="text">
6666
<string>Remove Score</string>
@@ -74,7 +74,7 @@
7474
<item row="3" column="1">
7575
<widget class="QPushButton" name="down">
7676
<property name="toolTip">
77-
<string>move current score down in list</string>
77+
<string>Move Current Score Down in List</string>
7878
</property>
7979
<property name="text">
8080
<string>Down</string>
@@ -84,7 +84,7 @@
8484
<item row="2" column="1">
8585
<widget class="QPushButton" name="up">
8686
<property name="toolTip">
87-
<string>move current score up in list</string>
87+
<string>Move Current Score Up in List</string>
8888
</property>
8989
<property name="text">
9090
<string>Up</string>
@@ -101,7 +101,7 @@
101101
<item>
102102
<widget class="QPushButton" name="createNew">
103103
<property name="toolTip">
104-
<string>create new album</string>
104+
<string>Create New Album</string>
105105
</property>
106106
<property name="text">
107107
<string>New</string>
@@ -111,7 +111,7 @@
111111
<item>
112112
<widget class="QPushButton" name="load">
113113
<property name="toolTip">
114-
<string>load an existing album</string>
114+
<string>Load an Existing Album</string>
115115
</property>
116116
<property name="text">
117117
<string>Load</string>

mscore/data/shortcuts.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -720,14 +720,6 @@
720720
<key>figured-bass</key>
721721
<seq>Ctrl+G</seq>
722722
</SC>
723-
<SC>
724-
<key>next-score</key>
725-
<seq>F3</seq>
726-
</SC>
727-
<SC>
728-
<key>prev-score</key>
729-
<seq>Shift+F3</seq>
730-
</SC>
731723
<SC>
732724
<key>transpose-up</key>
733725
<seq>F2</seq>

mscore/instrdialog.ui

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
</column>
212212
<column>
213213
<property name="text">
214-
<string>visible</string>
214+
<string>Visible</string>
215215
</property>
216216
</column>
217217
<column>
@@ -221,10 +221,10 @@
221221
</column>
222222
<column>
223223
<property name="text">
224-
<string>linked</string>
224+
<string>Linked</string>
225225
</property>
226226
<property name="toolTip">
227-
<string>staff linked to previous</string>
227+
<string>Staff Linked to Previous</string>
228228
</property>
229229
</column>
230230
</widget>

mscore/musescore.cpp

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -3803,35 +3803,6 @@ void MuseScore::loadFile(const QUrl& url)
38033803
networkManager->get(QNetworkRequest(url));
38043804
}
38053805

3806-
//---------------------------------------------------------
3807-
// gotoNextScore
3808-
//---------------------------------------------------------
3809-
3810-
void MuseScore::gotoNextScore()
3811-
{
3812-
int idx = tab1->currentIndex();
3813-
int n = tab1->count();
3814-
if (idx >= (n-1))
3815-
idx = 0;
3816-
else
3817-
++idx;
3818-
tab1->setCurrentIndex(idx);
3819-
}
3820-
3821-
//---------------------------------------------------------
3822-
// gotoPreviousScore
3823-
//---------------------------------------------------------
3824-
3825-
void MuseScore::gotoPreviousScore()
3826-
{
3827-
int idx = tab1->currentIndex();
3828-
if (idx == 0)
3829-
idx = tab1->count() -1;
3830-
else
3831-
--idx;
3832-
tab1->setCurrentIndex(idx);
3833-
}
3834-
38353806
//---------------------------------------------------------
38363807
// collectMatch
38373808
//---------------------------------------------------------
@@ -4333,9 +4304,9 @@ void MuseScore::cmd(QAction* a, const QString& cmd)
43334304
else if (cmd == "page-settings")
43344305
showPageSettings();
43354306
else if (cmd == "next-score")
4336-
gotoNextScore();
4307+
changeScore(1);
43374308
else if (cmd == "previous-score")
4338-
gotoPreviousScore();
4309+
changeScore(1);
43394310
else if (cmd == "transpose")
43404311
transpose();
43414312
else if (cmd == "tuplet-dialog")
@@ -4410,10 +4381,6 @@ void MuseScore::cmd(QAction* a, const QString& cmd)
44104381
addTempo();
44114382
else if (cmd == "metronome") // no action
44124383
;
4413-
else if (cmd == "next-score")
4414-
changeScore(1);
4415-
else if (cmd == "prev-score")
4416-
changeScore(-1);
44174384
else if (cmd == "viewmode") {
44184385
if (cs) {
44194386
if (cs->layoutMode() == LayoutPage) {

mscore/musescore.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,6 @@ class MuseScore : public QMainWindow {
386386
void showMediaDialog();
387387
void showAlbumManager();
388388
void showLayerManager();
389-
void gotoNextScore();
390-
void gotoPreviousScore();
391389
void updateUndoRedo();
392390
void cmdAddChordName2();
393391
static void convertCapella(Score*, Capella* cap);

0 commit comments

Comments
 (0)