Skip to content

Commit

Permalink
Merge pull request #3114 from IsaacWeiss/184381-dialog-titles-2.1
Browse files Browse the repository at this point in the history
Fix #184381: Unnecessary "MuseScore: " prepended to most window titles and wrong title of Split Staff dialog for 2.1
  • Loading branch information
lasconic committed Mar 28, 2017
2 parents ced3364 + ae31f1d commit a94d6c4
Show file tree
Hide file tree
Showing 69 changed files with 153 additions and 169 deletions.
2 changes: 1 addition & 1 deletion awl/colorlabel.cpp
Expand Up @@ -95,7 +95,7 @@ void ColorLabel::mousePressEvent(QMouseEvent*)
if (_pixmap)
return;
QColor c = QColorDialog::getColor(_color, this,
tr("MuseScore: Select Color"),
tr("Select Color"),
QColorDialog::ShowAlphaChannel
);
if (c.isValid()) {
Expand Down
8 changes: 4 additions & 4 deletions libmscore/scorefile.cpp
Expand Up @@ -384,7 +384,7 @@ bool Score::saveFile()
}

if (temp.error() != QFile::NoError) {
MScore::lastError = tr("MuseScore: Save File failed: %1").arg(temp.errorString());
MScore::lastError = tr("Save File failed: %1").arg(temp.errorString());
return false;
}
temp.close();
Expand All @@ -403,7 +403,7 @@ bool Score::saveFile()
if (dir.exists(backupName)) {
if (!dir.remove(backupName)) {
// if (!MScore::noGui)
// QMessageBox::critical(0, tr("MuseScore: Save File"),
// QMessageBox::critical(0, tr("Save File"),
// tr("Removing old backup file ") + backupName + tr(" failed"));
}
}
Expand All @@ -415,7 +415,7 @@ bool Score::saveFile()
if (dir.exists(name)) {
if (!dir.rename(name, backupName)) {
// if (!MScore::noGui)
// QMessageBox::critical(0, tr("MuseScore: Save File"),
// QMessageBox::critical(0, tr("Save File"),
// tr("Renaming old file <")
// + name + tr("> to backup <") + backupName + tr("> failed"));
}
Expand All @@ -431,7 +431,7 @@ bool Score::saveFile()
if (dir.exists(name)) {
if (!dir.remove(name)) {
// if (!MScore::noGui)
// QMessageBox::critical(0, tr("MuseScore: Save File"),
// QMessageBox::critical(0, tr("Save File"),
// tr("Removing old file") + name + tr(" failed"));
}
}
Expand Down
2 changes: 1 addition & 1 deletion mscore/album.cpp
Expand Up @@ -240,7 +240,7 @@ bool Album::read(const QString& p)
QFile f(_path);
if (!f.open(QIODevice::ReadOnly)) {
QMessageBox::warning(0,
QWidget::tr("MuseScore: Open Album failed"),
QWidget::tr("Open Album failed"),
QString(strerror(errno)),
QString::null, QWidget::tr("Quit"), QString::null, 0, 1);
return false;
Expand Down
14 changes: 7 additions & 7 deletions mscore/albummanager.cpp
Expand Up @@ -73,7 +73,7 @@ void AlbumManager::addClicked()
{
QStringList files = mscore->getOpenScoreNames(
tr("MuseScore Files") + " (*.mscz *.mscx)",
tr("MuseScore: Add Score")
tr("Add Score")
);
if (files.isEmpty())
return;
Expand All @@ -99,7 +99,7 @@ void AlbumManager::loadClicked()
{
QStringList files = mscore->getOpenScoreNames(
tr("MuseScore Album Files") + " (*.album)",
tr("MuseScore: Load Album")
tr("Load Album")
);
if (files.isEmpty())
return;
Expand Down Expand Up @@ -139,14 +139,14 @@ void AlbumManager::createScoreClicked()
saveDirectory = preferences.myScoresPath;
QString fname = QString("%1/%2.mscz").arg(saveDirectory).arg(album->name());
QString fn = mscore->getSaveScoreName(
QWidget::tr("MuseScore: Save Album into Score"),
QWidget::tr("Save Album into Score"),
fname,
filter
);
if (fn.isEmpty())
return;
if (!album->createScore(fn, checkBoxAddPageBreak->isChecked(), checkBoxAddSectionBreak->isChecked()))
QMessageBox::critical(mscore, QWidget::tr("MuseScore: Save File"), tr("Error while creating score from album."));
QMessageBox::critical(mscore, QWidget::tr("Save File"), tr("Error while creating score from album."));
}
}

Expand Down Expand Up @@ -304,7 +304,7 @@ void AlbumManager::writeAlbum()
QString home = preferences.myScoresPath;
QString albumName = album->name();
QString fn = mscore->getSaveScoreName(
QWidget::tr("MuseScore: Save Album"),
QWidget::tr("Save Album"),
albumName,
QWidget::tr("MuseScore Files") + " (*.album)"
);
Expand All @@ -320,14 +320,14 @@ void AlbumManager::writeAlbum()
if (!f.open(QIODevice::WriteOnly)) {
QString s = QWidget::tr("Open Album File\n%1\nfailed: ")
+ QString(strerror(errno));
QMessageBox::critical(mscore, QWidget::tr("MuseScore: Open Album File"), s.arg(album->path()));
QMessageBox::critical(mscore, QWidget::tr("Open Album File"), s.arg(album->path()));
return;
}
Xml xml(&f);
album->write(xml);
if (f.error() != QFile::NoError) {
QString s = QWidget::tr("Write Album failed: ") + f.errorString();
QMessageBox::critical(0, QWidget::tr("MuseScore: Write Album"), s);
QMessageBox::critical(0, QWidget::tr("Write Album"), s);
}
}

Expand Down
2 changes: 1 addition & 1 deletion mscore/albummanager.ui
Expand Up @@ -14,7 +14,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Album Manager</string>
<string>Album Manager</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/alsa.cpp
Expand Up @@ -667,7 +667,7 @@ void AlsaAudio::alsaLoop()
rt_param.sched_priority = 50;
int rv = pthread_setschedparam(pthread_self(), SCHED_FIFO, &rt_param);
if (rv == -1)
perror("MuseScore: set realtime scheduler failed");
perror("Set realtime scheduler failed");

if (!alsa->pcmStart()) {
alsa->pcmStop();
Expand Down
2 changes: 1 addition & 1 deletion mscore/articulation.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Articulation Properties</string>
<string>Articulation Properties</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_4">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/bend.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Bend Properties</string>
<string>Bend Properties</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<property name="verticalSpacing">
Expand Down
2 changes: 1 addition & 1 deletion mscore/breaksdialog.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Add/Remove Line Breaks</string>
<string>Add/Remove Line Breaks</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/capella.cpp
Expand Up @@ -2673,7 +2673,7 @@ Score::FileError importCapella(Score* score, const QString& name)
catch (Capella::Error errNo) {
if (!MScore::noGui) {
QMessageBox::warning(0,
QWidget::tr("MuseScore: Import Capella"),
QWidget::tr("Import Capella"),
QWidget::tr("Load failed: ") + cf.error(errNo),
QString::null, QWidget::tr("Quit"), QString::null, 0, 1);
}
Expand Down
2 changes: 1 addition & 1 deletion mscore/debugger/debugger.cpp
Expand Up @@ -598,7 +598,7 @@ void Debugger::updateElement(Element* el)
if (!found)
qDebug("Debugger: element not found %s\n", el->name());

setWindowTitle(QString("MuseScore: Debugger: ") + el->name());
setWindowTitle(QString("Debugger: ") + el->name());

ShowElementBase* ew = elementViews[int(el->type())];
if (ew == 0) {
Expand Down
2 changes: 1 addition & 1 deletion mscore/drumroll.cpp
Expand Up @@ -194,7 +194,7 @@ void DrumrollEditor::setStaff(Staff* st)
{
staff = st;
_score = staff->score();
setWindowTitle(tr("MuseScore: <%1> Staff: %2").arg(_score->name()).arg(st->idx()));
setWindowTitle(tr("<%1> Staff: %2").arg(_score->name()).arg(st->idx()));
TempoMap* tl = _score->tempomap();
TimeSigMap* sl = _score->sigmap();
for (int i = 0; i < 3; ++i)
Expand Down
4 changes: 2 additions & 2 deletions mscore/editdrumset.cpp
Expand Up @@ -370,7 +370,7 @@ void EditDrumset::save()
if (!f.open(QIODevice::WriteOnly)) {
QString s = tr("Open File\n%1\nfailed: ")
+ QString(strerror(errno));
QMessageBox::critical(mscore, tr("MuseScore: Open File"), s.arg(f.fileName()));
QMessageBox::critical(mscore, tr("Open File"), s.arg(f.fileName()));
return;
}
valueChanged(); //save last changes in name
Expand All @@ -381,7 +381,7 @@ void EditDrumset::save()
xml.etag();
if (f.error() != QFile::NoError) {
QString s = tr("Write File failed: ") + f.errorString();
QMessageBox::critical(this, tr("MuseScore: Write Drumset"), s);
QMessageBox::critical(this, tr("Write Drumset"), s);
}
}

Expand Down
2 changes: 1 addition & 1 deletion mscore/editdrumset.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Drumset</string>
<string>Edit Drumset</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/editinstrument.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Instrument Properties</string>
<string>Edit Instrument Properties</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="0">
Expand Down
2 changes: 1 addition & 1 deletion mscore/editraster.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Grid</string>
<string>Edit Grid</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/editstaff.ui
Expand Up @@ -23,7 +23,7 @@
</size>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Staff/Part Properties</string>
<string>Edit Staff/Part Properties</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="1" column="0" colspan="2">
Expand Down
2 changes: 1 addition & 1 deletion mscore/editstafftype.ui
Expand Up @@ -17,7 +17,7 @@
</size>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Staff Type</string>
<string>Edit Staff Type</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_4">
<item>
Expand Down
2 changes: 1 addition & 1 deletion mscore/editstyle.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Edit Style</string>
<string>Edit Style</string>
</property>
<layout class="QGridLayout" name="gridLayout_11">
<item row="0" column="1">
Expand Down
2 changes: 1 addition & 1 deletion mscore/excerptsdialog.ui
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>MuseScore: Parts</string>
<string>Parts</string>
</property>
<layout class="QGridLayout">
<item row="0" column="0">
Expand Down

0 comments on commit a94d6c4

Please sign in to comment.