Merge pull request #3813 from Jojo-Schmitz/inspector-accessibility

more inspector accessibility fixes, changes, additions
musescore · Jul 18, 2018 · d04f78d · d04f78d
2 parents df69562 + 5e01179
commit d04f78d
Show file tree

Hide file tree

Showing 34 changed files with 320 additions and 57 deletions.
diff --git a/mscore/inspector/inspector_accidental.ui b/mscore/inspector/inspector_accidental.ui
@@ -111,7 +111,11 @@
        </widget>
       </item>
       <item row="1" column="2">
-       <widget class="QComboBox" name="bracket"/>
+       <widget class="QComboBox" name="bracket">
+        <property name="accessibleName">
+         <string>Brackt type</string>
+        </property>
+       </widget>
       </item>
       <item row="1" column="1">
        <widget class="QLabel" name="label">

diff --git a/mscore/inspector/inspector_arpeggio.ui b/mscore/inspector/inspector_arpeggio.ui
@@ -78,6 +78,9 @@
       </property>
       <item row="0" column="0">
        <widget class="QCheckBox" name="playArpeggio">
+        <property name="accessibleName">
+         <string>Play</string>
+        </property>
         <property name="text">
          <string>Play</string>
         </property>

diff --git a/mscore/inspector/inspector_articulation.ui b/mscore/inspector/inspector_articulation.ui
@@ -234,7 +234,7 @@
       <item row="3" column="1">
        <widget class="QComboBox" name="ornamentStyle">
         <property name="accessibleName">
-         <string>Direction</string>
+         <string>Ornament style</string>
         </property>
         <item>
          <property name="text">
@@ -284,6 +284,9 @@
       </item>
       <item row="4" column="0" colspan="2">
        <widget class="QCheckBox" name="playArticulation">
+        <property name="accessibleName">
+         <string>Play</string>
+        </property>
         <property name="text">
          <string>Play</string>
         </property>

diff --git a/mscore/inspector/inspector_barline.ui b/mscore/inspector/inspector_barline.ui
@@ -79,7 +79,7 @@
       <item row="0" column="1">
        <widget class="QComboBox" name="type">
         <property name="accessibleName">
-         <string>Type</string>
+         <string>Style</string>
         </property>
        </widget>
       </item>
@@ -268,6 +268,9 @@
       </item>
       <item row="2" column="0" colspan="2">
        <widget class="QCheckBox" name="span">
+        <property name="accessibleName">
+         <string>Span to next staff</string>
+        </property>
         <property name="text">
          <string>Span to next staff</string>
         </property>

diff --git a/mscore/inspector/inspector_beam.ui b/mscore/inspector/inspector_beam.ui
@@ -63,6 +63,9 @@
    </item>
    <item>
     <widget class="QWidget" name="panel" native="true">
+     <property name="accessibleName">
+      <string>Local relayout</string>
+     </property>
      <layout class="QGridLayout" name="gridLayout">
       <property name="leftMargin">
        <number>3</number>

diff --git a/mscore/inspector/inspector_bend.ui b/mscore/inspector/inspector_bend.ui
@@ -97,6 +97,9 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="accessibleName">
+         <string>Play</string>
+        </property>
         <property name="text">
          <string>Play</string>
         </property>
@@ -153,6 +156,9 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="accessibleName">
+         <string>Font face</string>
+        </property>
        </widget>
       </item>
       <item row="1" column="0">
@@ -166,7 +172,11 @@
        </widget>
       </item>
       <item row="2" column="1">
-       <widget class="QSpinBox" name="fontSize"/>
+       <widget class="QSpinBox" name="fontSize">
+        <property name="accessibleName">
+         <string>Font size</string>
+        </property>
+       </widget>
       </item>
       <item row="2" column="2">
        <widget class="QToolButton" name="resetFontSize">
@@ -360,6 +370,9 @@
       </item>
       <item row="0" column="1">
        <widget class="QDoubleSpinBox" name="lineWidth">
+        <property name="accessibleName">
+         <string>Line width</string>
+        </property>
         <property name="suffix">
          <string>sp</string>
         </property>

diff --git a/mscore/inspector/inspector_bracket.ui b/mscore/inspector/inspector_bracket.ui
@@ -77,7 +77,11 @@
        <number>0</number>
       </property>
       <item row="0" column="1">
-       <widget class="QSpinBox" name="column"/>
+       <widget class="QSpinBox" name="column">
+        <property name="accessibleName">
+         <string>Column</string>
+        </property>
+       </widget>
       </item>
       <item row="0" column="0">
        <widget class="QLabel" name="label">

diff --git a/mscore/inspector/inspector_dynamic.ui b/mscore/inspector/inspector_dynamic.ui
@@ -109,7 +109,7 @@
       <item row="0" column="1">
        <widget class="QComboBox" name="dynRange">
         <property name="accessibleName">
-         <string>Dynamic Range</string>
+         <string>Dynamic range</string>
         </property>
         <item>
          <property name="text">
@@ -164,6 +164,9 @@
       </item>
       <item row="2" column="1">
        <widget class="QComboBox" name="placement">
+        <property name="accessibleName">
+         <string>Placement</string>
+        </property>
         <item>
          <property name="text">
           <string notr="true">Below</string>

diff --git a/mscore/inspector/inspector_element.ui b/mscore/inspector/inspector_element.ui
@@ -84,6 +84,9 @@
       </property>
       <item row="4" column="0" colspan="3">
        <widget class="QCheckBox" name="autoplace">
+        <property name="accessibleName">
+         <string>Automatic placement</string>
+        </property>
         <property name="text">
          <string>Automatic placement</string>
         </property>
@@ -165,6 +168,9 @@
         <property name="focusPolicy">
          <enum>Qt::TabFocus</enum>
         </property>
+        <property name="accessibleName">
+         <string>Visible</string>
+        </property>
         <property name="text">
          <string>Visible</string>
         </property>
@@ -222,6 +228,9 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="accessibleName">
+         <string>Offset</string>
+        </property>
        </widget>
       </item>
       <item row="2" column="0" colspan="3">

diff --git a/mscore/inspector/inspector_fermata.ui b/mscore/inspector/inspector_fermata.ui
@@ -89,7 +89,7 @@
       <item row="0" column="1">
        <widget class="QComboBox" name="placement">
         <property name="accessibleName">
-         <string>Direction</string>
+         <string>Placement</string>
         </property>
         <item>
          <property name="text">
@@ -176,6 +176,9 @@
       </item>
       <item row="2" column="0" colspan="2">
        <widget class="QCheckBox" name="playArticulation">
+        <property name="accessibleName">
+         <string>Play</string>
+        </property>
         <property name="text">
          <string>Play</string>
         </property>

diff --git a/mscore/inspector/inspector_fingering.ui b/mscore/inspector/inspector_fingering.ui
@@ -87,7 +87,11 @@
        </widget>
       </item>
       <item row="0" column="1">
-       <widget class="QComboBox" name="style"/>
+       <widget class="QComboBox" name="style">
+        <property name="accessibleName">
+         <string>Style</string>
+        </property>
+       </widget>
       </item>
       <item row="0" column="2">
        <widget class="QToolButton" name="resetStyle">

diff --git a/mscore/inspector/inspector_frametext.ui b/mscore/inspector/inspector_frametext.ui
@@ -89,7 +89,7 @@
       <item row="0" column="1">
        <widget class="QComboBox" name="style">
         <property name="accessibleName">
-         <string>substyle</string>
+         <string>Style</string>
         </property>
         <property name="sizeAdjustPolicy">
          <enum>QComboBox::AdjustToMinimumContentsLengthWithIcon</enum>

diff --git a/mscore/inspector/inspector_fret.ui b/mscore/inspector/inspector_fret.ui
@@ -109,6 +109,9 @@
       </item>
       <item row="0" column="1">
        <widget class="QDoubleSpinBox" name="mag">
+        <property name="accessibleName">
+         <string>Scale</string>
+        </property>
         <property name="minimum">
          <double>0.200000000000000</double>
         </property>
@@ -233,20 +236,30 @@
       </item>
       <item row="3" column="1">
        <widget class="QSpinBox" name="frets">
+        <property name="accessibleName">
+         <string>Frets</string>
+        </property>
         <property name="minimum">
          <number>1</number>
         </property>
        </widget>
       </item>
       <item row="2" column="1">
        <widget class="QSpinBox" name="strings">
+        <property name="accessibleName">
+         <string>Strings</string>
+        </property>
         <property name="minimum">
          <number>1</number>
         </property>
        </widget>
       </item>
       <item row="5" column="1">
-       <widget class="QSpinBox" name="barre"/>
+       <widget class="QSpinBox" name="barre">
+        <property name="accessibleName">
+         <string>Barre</string>
+        </property>
+       </widget>
       </item>
       <item row="3" column="2">
        <widget class="QToolButton" name="resetFrets">
@@ -293,7 +306,11 @@
        </widget>
       </item>
       <item row="6" column="1">
-       <widget class="QSpinBox" name="offset"/>
+       <widget class="QSpinBox" name="offset">
+        <property name="accessibleName">
+         <string>Offset</string>
+        </property>
+       </widget>
       </item>
       <item row="6" column="2">
        <widget class="QToolButton" name="resetOffset">

diff --git a/mscore/inspector/inspector_glissando.ui b/mscore/inspector/inspector_glissando.ui
@@ -89,10 +89,10 @@
       <item row="6" column="0">
        <widget class="QLabel" name="label_7">
         <property name="text">
-         <string>Size:</string>
+         <string>Font size:</string>
         </property>
         <property name="alignment">
-         <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+         <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
         </property>
         <property name="buddy">
          <cstring>fontSize</cstring>
@@ -128,8 +128,11 @@
       </item>
       <item row="9" column="0">
        <widget class="QLabel" name="label_2">
+        <property name="accessibleName">
+         <string>Play style</string>
+        </property>
         <property name="text">
-         <string>Style:</string>
+         <string>Play style:</string>
         </property>
         <property name="buddy">
          <cstring>glissandoStyle</cstring>
@@ -156,7 +159,7 @@
       <item row="9" column="1">
        <widget class="QComboBox" name="glissandoStyle">
         <property name="accessibleName">
-         <string>Play Style</string>
+         <string>Play style</string>
         </property>
         <item>
          <property name="text">
@@ -246,6 +249,9 @@
       </item>
       <item row="10" column="0" colspan="2">
        <widget class="QCheckBox" name="playGlissando">
+        <property name="accessibleName">
+         <string>Play</string>
+        </property>
         <property name="text">
          <string>Play</string>
         </property>
@@ -272,10 +278,17 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="accessibleName">
+         <string>Font face</string>
+        </property>
        </widget>
       </item>
       <item row="6" column="1">
-       <widget class="QSpinBox" name="fontSize"/>
+       <widget class="QSpinBox" name="fontSize">
+        <property name="accessibleName">
+         <string>Font size</string>
+        </property>
+       </widget>
       </item>
       <item row="7" column="1">
        <layout class="QHBoxLayout" name="horizontalLayout_2">
@@ -442,7 +455,7 @@
          <string>Style:</string>
         </property>
         <property name="alignment">
-         <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+         <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
         </property>
        </widget>
       </item>
@@ -452,7 +465,7 @@
          <string>Reset to default</string>
         </property>
         <property name="accessibleName">
-         <string>Reset 'Size' value</string>
+         <string>Reset 'Font size' value</string>
         </property>
         <property name="text">
          <string notr="true"/>