Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Search result shows empty palettes #7633

Closed
vshalkevich opened this issue Mar 5, 2021 · 2 comments · Fixed by #8441
Closed

[MU4 Issue] Search result shows empty palettes #7633

vshalkevich opened this issue Mar 5, 2021 · 2 comments · Fixed by #8441
Labels
P2 Priority: Medium

Comments

@vshalkevich
Copy link

Describe the bug
Search results even if there is no match - it shows empty palettes

To Reproduce
Steps to reproduce the behavior:

  1. Create a score
  2. Open "palettes" tab on the left side panel
  3. Enter "2" or "ch" or "dd" in a palettes search field

Expected behavior
Empty slots and palettes should not be shown if there is no match with letters in search field

Screenshots
image
Скриншот 21-12-2020 14 31 20
Скриншот 21-12-2020 14 33 05

Desktop (please complete the following information):
Windows 10 x64,
MacOS

@vshalkevich vshalkevich added this to To do in [MU4.0 - PALETTES] via automation Mar 5, 2021
@shoogle shoogle added this to the v4.0 milestone Mar 7, 2021
@vshalkevich vshalkevich added the P2 Priority: Medium label Mar 23, 2021
@wizofaus
Copy link
Contributor

Can't reproduce:
ch - shows the french violin clef
dd - shows a bunch of palette commands that have "add" in their name
2 - shows a bunch of palette commands that have 2 in their name
xy - shows no palette commands at all as expected

Propose this should be closed as already fixed.

@wizofaus
Copy link
Contributor

wizofaus commented Jun 28, 2021

...however it does seem that adding items to the score from any palette in search mode doesn't work...appears to be an issue in UserPaletteController::applyPaletteElement( )

wizofaus added a commit to wizofaus/MuseScore that referenced this issue Jun 28, 2021
[MU4.0 - PALETTES] automation moved this from To do to Done Jun 28, 2021
igorkorsukov pushed a commit that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants