Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: rename episodes_length to compute_episodes_length #91

Closed
RylanSchaeffer opened this issue Mar 25, 2022 · 0 comments
Closed

Comments

@RylanSchaeffer
Copy link

If I can make a suggestion, perhaps you could rename the function mushroom_rl.utils.dataset.episodes_length() to mushroom_rl.utils.dataset.compute_episodes_length(). This would better match your function naming convention (e.g. compute_J(), compute_metrics()) and would also allow me to name the returned variable episode_lengths.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant