Support for loading cover art images from local filesystem #408

zas · 2015-06-24T21:53:19Z

It adds a cover art provider, which, when enabled, looks for files like cover.jpg, etc.. in local directory (where sound files are) and use image files found as cover art.

Inspired by http://forums.musicbrainz.org/viewtopic.php?id=2859

Solves:
http://tickets.musicbrainz.org/browse/PICARD-137
http://tickets.musicbrainz.org/browse/PICARD-624

Related:
http://tickets.musicbrainz.org/browse/PICARD-257
http://tickets.musicbrainz.org/browse/PICARD-187

It tries to use image files from directories where files are found. Inspired by http://forums.musicbrainz.org/viewtopic.php?id=2859 Solves: http://tickets.musicbrainz.org/browse/PICARD-137 http://tickets.musicbrainz.org/browse/PICARD-624 Related: http://tickets.musicbrainz.org/browse/PICARD-257

phw · 2015-06-25T07:07:13Z

picard/coverart/providers/local.py

+
+    NAME = "Local"
+
+    _match_re = re.compile('^(?:cover|folder).*\.(?:jpe?g|png|gif|tiff?)$', re.IGNORECASE)


"AlbumArt" is also a typical name understood by many software. It's what I am using and it is pretty compatible. I remember switching to this naming for some reason, but I don't remember which software triggered it

Added in 8e966e4

Suggested by metabrainz#408 (comment)

Images aren't always downloaded.

mineo · 2015-06-25T08:07:49Z

picard/coverart/image.py

@@ -117,7 +117,14 @@ class CoverArtImage:
    is_front = None
    sourceprefix = "URL"

-    def __init__(self, url=None, types=[], comment='', data=None):
+    def __init__(self, url=None, types=[], comment='', data=None,
+                 from_file=None):


It took me a while to figure out that from_file is the filename (so a string) and not a simple boolean. Maybe rename it?

I also wonder why CoverArtImage needs to know about the possibility of images from files instead of a new LocalCoverArtImage (or something like that) class since we already have {Caa,CaaThumbnail,Tag}CoverArtImage subclasses?

You're right on both points, i'll improve that.

Reported by Mineo : metabrainz#408 (comment)

Not always a download.

Suggested by Mineo : metabrainz#408 (comment)

Examples: cover_back.jpg -> 'back' folder_back,spine.png -> 'spine', 'back' cover_my_title_back_anything.jpg -> 'back'

…naming

- list of checkboxes to enable/disabled each provider - re-orderable list items using drag'n'drop, allowing to define which provider should be executed first - save settings for providers order/enabled in one config list option

zas · 2015-06-26T13:41:41Z

@phw : can you test with your plugin ? i didnt try

- set a function to be called when 'current' item changes - it may be used to handle per-provider options in UI

… page - Revamp UI, use tabs for provider-specific options - Use regex check to validate the local cover art regex

… types

gentlecat · 2015-06-30T08:38:28Z

picard/ui/ui_options_cover.py

-        self.caprovider_caa.setText(_("Cover Art Archive"))
-        self.caprovider_whitelist.setText(_("Sites on the whitelist"))
-        self.gb_caa.setTitle(_("Cover Art Archive"))
+        self.ca_providers_groupbox.setTitle(_("Coverart Providers"))


Maybe it should be "Cover Art Providers" (in ui/options_cover.ui file too)?

Done in 2f3816e

@gentlecat

Suggested by @gentlecat in metabrainz#408 (comment)

- better separation between options of each provider - each provider has its own .ui file for specific options - tabs can be re-ordered by drag'n'drop or using buttons

zas · 2015-07-01T16:04:41Z

PR splitted in two separated PRs:
#411
#412

zas added 2 commits June 24, 2015 22:13

Move code storing data to metadata in its own method

b13b8ef

zas added the Experimental label Jun 24, 2015

phw reviewed Jun 25, 2015
View reviewed changes

zas added 5 commits June 25, 2015 09:45

Use a loop to register cover art providers

87e336f

Order the execution of providers based on a list of their names

98b1847

Local cover art provider: also match AlbumArt file prefix

8e966e4

Suggested by metabrainz#408 (comment)

Rename queue_downloads() to queue_images()

d45f1c9

Images aren't always downloaded.

Fix missing property initialization

287e6ad

mineo reviewed Jun 25, 2015
View reviewed changes

zas added 2 commits June 25, 2015 10:25

Queing -> Queuing

a2bb372

Reported by Mineo : metabrainz#408 (comment)

download_next_in_queue() -> next_in_queue()

917641a

Not always a download.

zas added a commit to zas/picard that referenced this pull request Jun 25, 2015

Introduce CoverArtImageFromFile

b12c12e

Suggested by Mineo : metabrainz#408 (comment)

Introduce CoverArtImageFromFile

2f3f760

Suggested by Mineo : metabrainz#408 (comment)

zas force-pushed the local_cover_art branch from b12c12e to 2f3f760 Compare June 25, 2015 09:10

zas added 5 commits June 25, 2015 11:48

Fix missing self.

1b24ae7

Remove useless parameter

4db6bab

Add experimental support for types from filename

a1297cb

Examples: cover_back.jpg -> 'back' folder_back,spine.png -> 'spine', 'back' cover_my_title_back_anything.jpg -> 'back'

Povide compatibility with existing plugins after queue_downloads() re…

b412517

…naming

Redesign the UI and options for cover art providers

5048d25

- list of checkboxes to enable/disabled each provider - re-orderable list items using drag'n'drop, allowing to define which provider should be executed first - save settings for providers order/enabled in one config list option

zas added 6 commits June 27, 2015 09:06

Use self.__class__.__name__ instead of hardcoded class name

9b64cf9

SortCheckListView: add onCurrentChange()

00eebe3

- set a function to be called when 'current' item changes - it may be used to handle per-provider options in UI

Merge remote-tracking branch 'upstream/master' into local_cover_art

b48f223

Provide an upgrade function for cover art providers options

42eaa22

Remove debug print

09e28dc

Make regex checking code shared among options page

0066624

zas added 5 commits June 29, 2015 20:55

Allow user to configure local cover art regexp from cover art options…

243643e

… page - Revamp UI, use tabs for provider-specific options - Use regex check to validate the local cover art regex

Merge remote-tracking branch 'upstream/master' into local_cover_art

06c0e99

Add a Default button to reset local cover art regex, and a note about…

76b2eb6

… types

Improve the Cover Art options UI a bit

ee6f994

Add a note about re-ordering providers by drag'n'drop

c63b23c

gentlecat reviewed Jun 30, 2015
View reviewed changes

zas added 6 commits June 30, 2015 11:36

Coverart Providers -> Cover Art Providers

2f3816e

Suggested by @gentlecat in metabrainz#408 (comment)

Each cover art provider is now in a re-orderable tab

c7c6d03

- better separation between options of each provider - each provider has its own .ui file for specific options - tabs can be re-ordered by drag'n'drop or using buttons

Remove now unused sortchecklist

ea9454f

Remove extra blank line

e16720e

Introduce ProviderOptions class

0ce4a1c

Move provider-specific options and their UI to the provider itself

d3b1780

zas closed this Jul 1, 2015

zas deleted the local_cover_art branch March 30, 2019 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for loading cover art images from local filesystem #408

Support for loading cover art images from local filesystem #408

zas commented Jun 24, 2015

phw Jun 25, 2015

zas Jun 25, 2015

mineo Jun 25, 2015

zas Jun 25, 2015

zas commented Jun 26, 2015

gentlecat Jun 30, 2015

zas Jun 30, 2015

gentlecat Jun 30, 2015

zas commented Jul 1, 2015


		NAME = "Local"

		_match_re = re.compile('^(?:cover\|folder).*\.(?:jpe?g\|png\|gif\|tiff?)$', re.IGNORECASE)

Support for loading cover art images from local filesystem #408

Support for loading cover art images from local filesystem #408

Conversation

zas commented Jun 24, 2015

phw Jun 25, 2015

Choose a reason for hiding this comment

zas Jun 25, 2015

Choose a reason for hiding this comment

mineo Jun 25, 2015

Choose a reason for hiding this comment

zas Jun 25, 2015

Choose a reason for hiding this comment

zas commented Jun 26, 2015

gentlecat Jun 30, 2015

Choose a reason for hiding this comment

zas Jun 30, 2015

Choose a reason for hiding this comment

gentlecat Jun 30, 2015

Choose a reason for hiding this comment

zas commented Jul 1, 2015