Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences not saved for ESR builds #15

Closed
794 opened this issue Sep 6, 2017 · 5 comments
Closed

Preferences not saved for ESR builds #15

794 opened this issue Sep 6, 2017 · 5 comments

Comments

@794
Copy link

794 commented Sep 6, 2017

Screenshot here.

As you can see, it won't let me switch to Google+ comments, the button for it is gone. If there isn't a reddit post made for the video it'll just say "no posts found" and I can't switch to normal YouTube comments.

Also, while it isn't as big a deal, it also says "commenting as: undefined" instead of my username.

Using Firefox 52.3 ESR.

@mustafakalash
Copy link
Owner

You need to enable the switch to Google+ button in the options. Head to about:addons and click on options next to the entry for Reddit on YouTube. You can customize these settings there. Please let me know if this doesn't resolve your issue.

@794
Copy link
Author

794 commented Sep 6, 2017

Ticking those options has no effect. After clicking 'save', then closing and reopening the options the boxes are unticked again.

@mustafakalash
Copy link
Owner

I've been able to reproduce this issue specifically with the ESR build, thank you.

@mustafakalash mustafakalash changed the title Can't switch to G+ comments Preferences not saved for ESR builds Sep 6, 2017
@mustafakalash mustafakalash removed the bug label Sep 11, 2017
@mustafakalash
Copy link
Owner

For version 52.3, you must manually enable the storage API used by Reddit on YouTube's preferences. Please follow these instructions:

  1. Type about:config into the URL bar
  2. Click "I accept the risk!"
  3. Search storage.sync and double click webextensions.storage.sync.enabled so that its value is true

@794
Copy link
Author

794 commented Sep 12, 2017

Great, that's fixed it. Thanks for actually finding the fix. Another dev of an add-on I had a problem with recently just said "oh well figure it out yourself". So thanks again for going to the length of solving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants