Draft: Closes #255. Hold NASA Cp constant when temp is out-of-bounds. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the temperature is out-of-bounds with the NASA polynomials, hold the Cp constant and adjust the enthalpy and entropy accordingly. Note: this code was mostly authored by Alireza Mazaheri of NASA LaRC. See mutationpp#255. Closes mutationpp#255.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 71.65% 71.97% +0.31%
==========================================
Files 135 135
Lines 9089 9137 +48
==========================================
+ Hits 6513 6576 +63
+ Misses 2576 2561 -15 ☔ View full report in Codecov by Sentry. |
Add Matthew Goodson and Alireza Mazaheri to the contributors list. See mutationpp#255.
Update the version to 1.2.0. See mutationpp#255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255. When the temperature is out-of-bounds with the NASA polynomials, hold the Cp constant and adjust the enthalpy and entropy accordingly.
Note: this code was mostly authored by Alireza Mazaheri of NASA LaRC.