Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/locale_rails/i18n.rb:28:in supported_locales=': undefined method set_app_language_tags' for I18n::Locale:Module (NoMethodError) #2

Open
pupeno opened this issue Apr 29, 2010 · 8 comments

Comments

@pupeno
Copy link
Contributor

pupeno commented Apr 29, 2010

In my code I have this line to set up the locales:

I18n.supported_locales = ["en", "de"]

which recently started to generate this error:

$ ./script/server 
=> Booting WEBrick
=> Rails 2.3.5 application starting on http://0.0.0.0:3000
/Users/pupeno/.rvm/gems/ruby-1.8.7-p174/gems/rails-2.3.5/lib/rails/gem_dependency.rb:119:Warning: Gem::Dependency#version_requirements is deprecated and will be removed on or after August 2010.  Use #requirement
default config
/Users/pupeno/.rvm/gems/ruby-1.8.7-p174/gems/locale_rails-2.0.5/lib/locale_rails/i18n.rb:28:in `supported_locales=': undefined method `set_app_language_tags' for I18n::Locale:Module (NoMethodError)

Probably I updated something, but I'm not sure what as I haven't been working on this project for the past week or so.

@pupeno
Copy link
Contributor Author

pupeno commented Apr 29, 2010

Apparently the issue is that a I18n::Locale module was created (somewhere, who knows!) and Locale in I18n finds that instead of ::Locale. It seems replacing Locale with ::Locale fixes this issue.

@pupeno
Copy link
Contributor Author

pupeno commented Apr 29, 2010

Kind of fixed it here: http://github.com/pupeno/locale_rails/commit/6f6cd97432254cd8d3364c1be5e187433132ca19

There was one test I couldn't get to pass, but I wasn't sure if it was passing before.

@scambra
Copy link
Contributor

scambra commented May 27, 2010

I have fixed that test here:
http://github.com/scambra/locale_rails/commit/88518e6c5a86e8f95f0aa40ada34587daa6080f0

Setting I18n.locale was failing with rails-2.3.8 because way of storing locale in the thread was changed.

@pupeno
Copy link
Contributor Author

pupeno commented Jun 14, 2010

Masao, can we get a release of this gem with this fix?

@mutoh
Copy link
Owner

mutoh commented Jun 15, 2010

Sorry for late. I applied your patches.
I'll release this as soon as I can, but I'm so busy in my business now....

@scambra
Copy link
Contributor

scambra commented Jun 16, 2010

There is a failing test now. My patches, which fix that failing test, were not pulled

@mutoh
Copy link
Owner

mutoh commented Jun 24, 2010

I applied all your patch.(I've not test it yet by myself).

@scambra
Copy link
Contributor

scambra commented Jun 29, 2010

All tests pass now, can you release a new gem compatible with rails 2.3.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants