Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading RAW file as default rendering #113

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Loading RAW file as default rendering #113

merged 3 commits into from
Apr 5, 2021

Conversation

muukii
Copy link
Collaborator

@muukii muukii commented Apr 5, 2021 •
edited
Loading

image

muukii
muukii commented Apr 5, 2021
View reviewed changes
Sources/BrightroomEngine/DataSource/ImageProvider.swift
@@ -101,7 +105,86 @@ public final class ImageProvider: Equatable, StoreComponentType {
#if os(iOS)

private var cancellable: VergeAnyCancellable?


public init(rawData: Data) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New

Sources/BrightroomEngine/DataSource/ImageProvider.swift

}

public init(rawDataURL: URL) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New

@muukii muukii marked this pull request as ready for review April 5, 2021 16:46
@muukii muukii changed the title Processing RAW file Loading RAW file Apr 5, 2021
@muukii muukii changed the title Loading RAW file Loading RAW file as default rendering Apr 5, 2021
@muukii muukii merged commit 5ff569f into main Apr 5, 2021
@muukii muukii deleted the muukii/raw branch April 5, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Group: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@muukii