Make initializer failable in case the pixel format is unsupported #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntnmrndn
force-pushed
the
fix_bad_pixel_format
branch
from
1f3a37c
to
3465751
Compare
…s for image source creation Fix crash on extreme aspect ratios images
muukii
reviewed
Jun 9, 2021
Comment on lines
294
to
296
| let targetSize: CGSize = { | ||
| imageSize.scaled(maxPixelSize: maxPixelSize) | ||
| }() |
There was a problem hiding this comment.
@ntnmrndn
any reason? but I don't care
There was a problem hiding this comment.
Not anymore. I edited it
muukii
reviewed
Jun 9, 2021
|
|
||
| /// Checks that the pixel format is supported by core graphics. | ||
| /// Throws in case an error is found. | ||
| public static func validatePixelFormat(_ image: UIImage) throws { |
muukii
reviewed
Jun 9, 2021
Comment on lines
+269
to
+282
| public static func makeResizedCGImage( | ||
| from sourceImage: CGImage, | ||
| maxPixelSizeHint: CGFloat | ||
| ) -> CGImage? { | ||
| let maxPixelSize: CGFloat = { | ||
| let largestSide = max(sourceImage.size.width, sourceImage.size.height) | ||
| let smallestSide = min(sourceImage.size.width, sourceImage.size.height) | ||
| guard smallestSide >= maxPixelSizeHint else { | ||
| return largestSide | ||
| } | ||
| return largestSide * maxPixelSizeHint / smallestSide | ||
| }() | ||
| return makeResizedCGImage(from: sourceImage, maxPixelSize: maxPixelSize) | ||
| } |
There was a problem hiding this comment.
thank you for fixing it.
Should we make the original one internal method? is it okay to keep it?
There was a problem hiding this comment.
which means, integrating this operation and below primitive operation.
There was a problem hiding this comment.
I thought it's ok to have both; since they do different things. If an user is confident that his image can use the maxPixelSize version it's ok to use it.
muukii
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.