Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal .apk file to github releases #24

Closed
emanuelb opened this issue May 14, 2021 · 3 comments
Closed

Add universal .apk file to github releases #24

emanuelb opened this issue May 14, 2021 · 3 comments

Comments

@emanuelb
Copy link

Add universal .apk file to assets in github releases & add description of the release in:
https://github.com/muun/apollo/releases/

@champo
Copy link
Contributor

champo commented May 28, 2021

Hi @emanuelb, what would you know need to download the APK for? We don't want to encourage users to install outside of stores due to lack of automatic updates. If you need an APK, Actions for tags have them already.

@emanuelb
Copy link
Author

The only store that should be encouraged on Android is F-Droid main repo, related issue for publishing the app on F-Droid is: #6 and in this issue 2 different people ask about availability of apk (which if there wasn't already issue about f-droid I opened issue myself from my "template" which also contain explanations/related information... see info in issue I opened for another lightning bitcoin wallet blixt: hsjoberg/blixt-wallet#329 )

Regarding automatic updates, even app downloaded from google-play doesn't ensure automatic updates, because:

  1. automatic updates can be disabled in store app (globally or manually for the bitcoin app which is floating recommendation to not update immediately but wait and update manually later when no alarms are set, aka people complain on severe bugs or lost funds, etc...)
  2. app might be installed not via store on the phone (Google-Play-Store or AuroraStore https://auroraoss.com/), thus no automatic update mechanism, this can happen when the APK is downloaded from places like: https://apk.support/ ApkPure, ApkMirror and others...

Downloading APK for old versions is not possible via the GooglePlay directly (Some Apk mirror/downloading sites offer downloading of old versions)

You can see list of more then 30 issues for bitcoin wallets to add APK downloads outside GooglePlay (Mostly Github Releases) in : https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/228 (Will add comment to this issue later with more details/explanation why it's needed/useful)

If you need an APK, Actions for tags have them already.

It's kinda solution to download APK of tagged version which is less visible/approachable then github releases (which also include changelog for the release)

@champo
Copy link
Contributor

champo commented May 31, 2021

Regarding automatic updates, even app downloaded from google-play doesn't ensure automatic updates

True, but not using a store is 100% guarantee of that and that's not an acceptable trade-off for us.

Downloading APK for old versions is not possible via the GooglePlay directly

Not sure why you'd want old versions, but you can always build from source if you needed them.

It's kinda solution to download APK of tagged version which is less visible/approachable then github releases (which also include changelog for the release)

Like I said, less visible is a feature. If someone has good reasons to not use other distribution methods, they can go ahead and put the burden on themselves, but I won't make it for users that might not understand the trade-offs to do so.

@champo champo closed this as completed May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants