feat: add bttv/ffz emote support

[juaoose]

This adds support for BTTV emotes for chat history.

• I am not conviced the current parsing is very efficient?
• I used the mechanism you used for badges, does it apply
• Would FFZ ones fit in the same model (renamed) or would it be better to have another ChangeNotifier for FFZ?

[kevmo314]

I am not conviced the current parsing is very efficient?

Yeah the rest of the PR looks good, I'll leave a few comments on the parsing to improve that.

I used the mechanism you used for badges, does it apply

Yes this is fine :)

Would FFZ ones fit in the same model (renamed) or would it be better to have another ChangeNotifier for FFZ?

I think putting them in the same model is fine. We can call it ThirdPartyEmotesModel or something.

[kevmo314]

Code looks good :) I think we should refactor the processing into the model in the future bc there's some benefits to that for future features, but that can be done in a separate PR. I'll take a look after this one gets in.

Nice work!

[juaoose]

Code looks good :) I think we should refactor the processing into the model in the future bc there's some benefits to that for future features, but that can be done in a separate PR. I'll take a look after this one gets in.

Nice work!

I actually asked about the function location because I was thinking on how to test it compared to the other parsing functions in this file. And there is some refactoring to be made to integrate these to the emote picker too.

[kevmo314]

I actually asked about the function location because I was thinking on how to test it compared to the other parsing functions in this file. And there is some refactoring to be made to integrate these to the emote picker too.

Ah yeah, I think testing becomes easier if this complex logic is refactored into the model. But y'know, merge first think later. Lots of people will be very happy with BTTV support :)