Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poster slot fade after play before playing #824

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Feb 15, 2024

fix #823

@luwes luwes self-assigned this Feb 15, 2024
@luwes luwes requested review from heff and a team as code owners February 15, 2024 14:23
Copy link

vercel bot commented Feb 15, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (3ea80df) 78.55% compared to head (26fc77e) 78.44%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/js/controller.js 33.33% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   78.55%   78.44%   -0.12%     
==========================================
  Files          59       59              
  Lines       11080    11104      +24     
==========================================
+ Hits         8704     8710       +6     
- Misses       2376     2394      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 2:33pm

@cjpillsbury
Copy link
Collaborator

Per @luwes's advice: before/after smoke tested using

Using dev tools, disabled cache and throttled network to slow 3g. Once controls rendered, attempted to play using play button.

  • Before: poster image would fade with controls
  • After: poster image stays rendered until the media has loaded.
    🎉

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@luwes luwes merged commit 39ba757 into muxinc:main Feb 15, 2024
6 of 8 checks passed
@luwes luwes deleted the fix-poster branch February 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slotted poster transition bug
2 participants