fix: buggy chapter segments rendering #825
Conversation
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| mediaEvents: ['loadstart', 'loadedmetadata'], | ||
| textTracksEvents: ['addtrack', 'removetrack'], | ||
| mediaEvents: ['loadstart'], | ||
| textTracksEvents: ['addtrack', 'removetrack', 'change'], |
There was a problem hiding this comment.
I added change as well because it makes sense to re-render when the active chapters track changes
There was a problem hiding this comment.
cool def makes sense to me.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
- Coverage 78.55% 78.45% -0.11%
==========================================
Files 59 59
Lines 11080 11112 +32
==========================================
+ Hits 8704 8718 +14
- Misses 2376 2394 +18 ☔ View full report in Codecov by Sentry. |
luwes
force-pushed
the
fix-chapter-segs
branch
from
9827396
to
19ca6e2
Compare
| const chaptersTrack = media.querySelector('track[kind="chapters"][default][src]'); | ||
| chaptersTrack?.addEventListener('load', callback); | ||
| }, | ||
| mediaUnsetCallback(media, callback) { |
There was a problem hiding this comment.
lol started peeping this before I got pulled away and looks like you anticipated the cleanup concern already. 🔥
don't love this but I couldn't get it to work otherwise.