Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shifting time box elements with arrow #829

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Feb 18, 2024

test url: https://media-chrome-docs-git-fork-luwes-range-box-arrow-mux.vercel.app/docs/en/components/media-time-range

  • adds logic so children in the time range boxes shift closer to the time position, works for the preview and current box
  • adds a built-in arrow which also shifts similarly to media-time-display and media-preview-time-display

@luwes luwes self-assigned this Feb 18, 2024
@luwes luwes requested review from heff and a team as code owners February 18, 2024 12:51
Copy link

vercel bot commented Feb 18, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 60.69364% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 78.26%. Comparing base (3ea80df) to head (e1fe14d).
Report is 16 commits behind head on main.

❗ Current head e1fe14d differs from pull request most recent head 99b6889. Consider uploading reports for the commit 99b6889 to get more accurate results

Files Patch % Lines
src/js/media-time-range.js 60.69% 68 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   78.55%   78.26%   -0.30%     
==========================================
  Files          59       59              
  Lines       11080    11239     +159     
==========================================
+ Hits         8704     8796      +92     
- Misses       2376     2443      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes changed the title feat: shifting time box elements + built-in arrow tip feat: shifting time box elements + tooltips (WIP) Feb 18, 2024
Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 4:44pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 4:44pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 4:44pm

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@luwes luwes merged commit 3bc02dc into muxinc:main Mar 1, 2024
6 checks passed
@luwes luwes deleted the range-box-arrow branch March 1, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants