Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move menu components to stable #836

Merged
merged 13 commits into from
Mar 4, 2024
Merged

feat: move menu components to stable #836

merged 13 commits into from
Mar 4, 2024

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Mar 1, 2024

this moves the experimental menu components to stable and in the root of the src folder.
this will load all the menu components by default, will also increase bundle size.

@luwes luwes self-assigned this Mar 1, 2024
@luwes luwes requested review from heff and a team as code owners March 1, 2024 17:15
Copy link

vercel bot commented Mar 1, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:42pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:42pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:42pm

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 92.76316% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.32%. Comparing base (3ea80df) to head (e9880d8).
Report is 18 commits behind head on main.

Files Patch % Lines
src/js/media-chrome-menu-item.js 42.85% 4 Missing ⚠️
src/js/media-time-range.js 0.00% 4 Missing ⚠️
src/js/media-fullscreen-button.js 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   78.55%   72.32%   -6.24%     
==========================================
  Files          59       79      +20     
  Lines       11080    15406    +4326     
==========================================
+ Hits         8704    11142    +2438     
- Misses       2376     4264    +1888     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant