Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chapter preview fine tuning #840

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Mar 5, 2024

@luwes luwes self-assigned this Mar 5, 2024
@luwes luwes requested review from heff and a team as code owners March 5, 2024 21:13
Copy link

vercel bot commented Mar 5, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 4:14pm
media-chrome-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 4:14pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 4:14pm

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.36%. Comparing base (3ea80df) to head (c7696c1).
Report is 20 commits behind head on main.

❗ Current head c7696c1 differs from pull request most recent head 0735bd7. Consider uploading reports for the commit 0735bd7 to get more accurate results

Files Patch % Lines
src/js/media-preview-chapter-display.js 0.00% 5 Missing ⚠️
src/js/media-store/request-map.js 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   78.55%   72.36%   -6.20%     
==========================================
  Files          59       79      +20     
  Lines       11080    15417    +4337     
==========================================
+ Hits         8704    11156    +2452     
- Misses       2376     4261    +1885     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving with one nitpick blocker (added a suggestion in case you wanna just commit it and merge)

src/js/media-store/request-map.js Outdated Show resolved Hide resolved
Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
@luwes luwes merged commit 6d28ab8 into muxinc:main Mar 6, 2024
1 of 4 checks passed
@luwes luwes deleted the chapter-preview-fix branch March 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants