fix: clean up media-time-display conditions for duration vs. seekable… #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…End usage (display and aria label).
|
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 78.55% 72.34% -6.22%
==========================================
Files 59 79 +20
Lines 11080 15427 +4347
==========================================
+ Hits 8704 11160 +2456
- Misses 2376 4267 +1891 ☔ View full report in Codecov by Sentry. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
heff
approved these changes
Mar 11, 2024
src/js/media-time-display.js
Outdated
| @@ -50,7 +55,12 @@ const DEFAULT_MISSING_TIME_PHRASE = 'video not loaded, unknown time.'; | |||
| const updateAriaValueText = (el) => { | |||
| const currentTime = el.mediaCurrentTime; | |||
| const [, seekableEnd] = el.mediaSeekable ?? []; | |||
| const endTime = el.mediaDuration || seekableEnd; | |||
| let endTime; | |||
There was a problem hiding this comment.
We check for endTime == null later on, which makes me feel like this should now either default to null, or we should check for undefined or !endTime later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…End usage (display and aria label).
Mostly relevant for "DVR" cases.