Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Type is wrong for Asset type #86

Closed
alexarena opened this issue Dec 29, 2020 · 2 comments
Closed

[Bug] Type is wrong for Asset type #86

alexarena opened this issue Dec 29, 2020 · 2 comments

Comments

@alexarena
Copy link

On the Asset interface, the max_stored_resolution? is defined as 'Audio-only' | 'SD' | 'HD' | 'FHD' | 'UHD'. In practice, the Mux API returns Audio only (no -).

I think the fix for this would just be to change the definition in Asset.ts to reflect what's being returned from your API in practice, but I wanted to open as an issue first to confirm that this is in fact a bug.

@philcluff
Copy link
Collaborator

Get @alexarena, thanks for raising this, indeed it looks like this is incorrect, the API returns Audio only as you described.

I'll propagate this change through our SDKs and documentation.

Thanks!

@philcluff
Copy link
Collaborator

This is addressed in #87

@aminamos aminamos closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants