New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some issue #2

Merged

muyexi merged 4 commits into muyexi:master from tentenlee100:master

Sep 15, 2018

Contributor

tentenlee100 commented Sep 14, 2018

let childViewController can use dismissSemiModalView function
before get saved options, check option data type is match
reduce use swift unconditional unwrapping(!), sometimes will crash
objc_setAssociatedObject save in targetVC or rootVc , because when call dismissSemiModalView in the childViewController, it can not get semiModalViewController and semiModalDismissBlock

tentenlee100 added 4 commits

September 14, 2018 17:00


          [Update] check options data type, if type do not match, will use defa…

75096c7

…ult value


          [Fix] reduce use swift unconditional unwrapping(!), sometimes will crash

cef1d27


          [Add] let dismiss function can used

421c823


          [Change] save options in rootVC, and save semiModalViewController and…

5a6e870

… semiModalDismissBlock in targetVC

Owner

muyexi commented Sep 15, 2018

Thanks for contributing, @tentenlee100 🎉

muyexi merged commit 2d709a4 into muyexi:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment