Skip to content

Commit

Permalink
Merge pull request #723 from mv1388/remove_key_checking_in_bash_scripts
Browse files Browse the repository at this point in the history
Remove key path checking if it is provided since it is automatically found
  • Loading branch information
mv1388 committed Aug 6, 2022
2 parents c96216f + 3543a53 commit 70becd2
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 10 deletions.
6 changes: 0 additions & 6 deletions bin/AWS/create_instance.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,6 @@ case $key in
esac
done

if [ "$key_path" == "" ] ; then
echo "Not provided required parameters"
usage
exit
fi

if [ "$DL_framework" == "TF" ]; then
py_env="tensorflow"
elif [ "$DL_framework" == "pytorch" ]; then
Expand Down
2 changes: 1 addition & 1 deletion bin/AWS/prepare_instance.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ case $key in
esac
done

if [ "$key_path" == "" ] || [ "$ec2_instance_address" == "" ] || [ "$DL_framework" == "" ] || [ "$AIToolbox_version" == "" ]; then
if [ "$ec2_instance_address" == "" ] || [ "$DL_framework" == "" ] || [ "$AIToolbox_version" == "" ]; then
echo "Not provided required parameters"
usage
exit
Expand Down
2 changes: 1 addition & 1 deletion bin/AWS/submit_job.sh
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ case $key in
esac
done

if [ "$key_path" == "" ] || [ "$local_project_path" == "" ]; then
if [ "$local_project_path" == "" ]; then
echo "Not provided required parameters"
usage
exit
Expand Down
2 changes: 1 addition & 1 deletion bin/AWS/update_experiments_on_AWS.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ case $key in
esac
done

if [ "$key_path" == "" ] || [ "$ec2_instance_address" == "" ] || [ "$local_project_path" == "" ]; then
if [ "$ec2_instance_address" == "" ] || [ "$local_project_path" == "" ]; then
echo "Not provided required parameters"
usage
exit
Expand Down
2 changes: 1 addition & 1 deletion bin/AWS/update_package_on_AWS.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ case $key in
esac
done

if [ "$key_path" == "" ] || [ "$ec2_instance_address" == "" ] || [ "$DL_framework" == "" ] || [ "$AIToolbox_version" == "" ]; then
if [ "$ec2_instance_address" == "" ] || [ "$DL_framework" == "" ] || [ "$AIToolbox_version" == "" ]; then
echo "Not provided required parameters"
usage
exit
Expand Down

0 comments on commit 70becd2

Please sign in to comment.