Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magit colors #4

Closed
Wasabichicken opened this issue Nov 1, 2017 · 3 comments
Closed

Magit colors #4

Wasabichicken opened this issue Nov 1, 2017 · 3 comments

Comments

@Wasabichicken
Copy link

Hi, and thank you for a neat little theme. :)

I wonder if you have tested this theme with https://magit.vc/, and if so, if you like the colors being used there. If you haven't, then I would like to suggest that the chunk selection highlight color in the Magit status window be changed from the (rather contrasting IMHO) blue into a more neutral grey, preferably only slightly brighter than the ordinary (non-highlighted) grey background.

It's something that I think Zenburn does correctly. When looking at diffs/chunks, I prefer to only have the red/green diff lines stand out and the rest be more neutral colors.

@mvarela
Copy link
Owner

mvarela commented Nov 1, 2017

Hi,
I'm not sure which case is exactly the one you're referring to, but I guess it was the face for magit-diff-highlight, which was set to bg+05, which is that stronger blue. It seems that in Zenburn, the foreground is also hard-coded. I've modified it now so it's slightly different (both fg and bg slightly muted).
Here are a couple of screenshots with the changes.
screen shot 2017-11-01 at 20 18 05
screen shot 2017-11-01 at 20 20 41

Let me know if this is along the lines you were thinking :)

@Wasabichicken
Copy link
Author

Nailed it. That is precisely along the lines I'm thinking!

@mvarela
Copy link
Owner

mvarela commented Nov 1, 2017

Excellent!

@mvarela mvarela closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants