Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document.documentElement?.clientHeight is not updating on latest iOS safari #73

Closed
ogroppo opened this issue Nov 1, 2021 · 4 comments
Closed

document.documentElement?.clientHeight is not updating on latest iOS safari #73

ogroppo opened this issue Nov 1, 2021 · 4 comments

Comments

@ogroppo
Copy link

ogroppo commented Nov 1, 2021

on iOS 15.0.2 when the footer slides down this rule breaks

https://github.com/mvasin/react-div-100vh/blob/master/packages/react-div-100vh/src/index.tsx#L49

because clientHeight is always the same, innerHeight seems to behave correctly
@mvasin
Copy link
Owner

mvasin commented Nov 1, 2021

Hi @ogroppo, thanks for the report! Would you like to create an MR?

@mvasin
Copy link
Owner

mvasin commented Nov 7, 2021

Hi @ogroppo! I released this change https://github.com/mvasin/react-div-100vh/pull/74/files as react-div-100vh@0.7.0-beta.1. Can you try it out?

@ogroppo
Copy link
Author

ogroppo commented Nov 8, 2021

Hi there! Apologies I had no time whatsoever even to contribute with this little change, anyway, it looks good on my devices ✅

@mvasin
Copy link
Owner

mvasin commented Nov 9, 2021

Perfect! I published the updated version under version 0.7.0.

@mvasin mvasin closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogroppo @mvasin